Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-encodes FQDN str with punycode to improve compatibility #66

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

tkzt
Copy link
Contributor

@tkzt tkzt commented Nov 29, 2023

Fixes: #62

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e975ed5) 62.90% compared to head (0e3b2a8) 63.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   62.90%   63.07%   +0.17%     
==========================================
  Files           9        9              
  Lines         585      585              
==========================================
+ Hits          368      369       +1     
+ Misses        217      216       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greyli greyli merged commit 06cd610 into waynerv:master Nov 29, 2023
20 checks passed
@greyli
Copy link
Collaborator

greyli commented Nov 29, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EncodeError occurred when FQDN string contains non-ascii character
2 participants