Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WebdriverIOs driver setup mechanism #105

Conversation

seanpoulter
Copy link
Contributor

Context

This is my attempt to drive #94 ahead. I believe your branch was very close and mostly needed to set the browserVersion.

Proposed Changes

  • Remove npm packges for chromedriver and wdio-chromedriver-service
  • Use WebdriverIO's setup mechanism
    • Do not download ChromeDriver
  • Remove unused utilities

Questions

  • Would you rather review on a call?
  • What do we need to do to support Chromium/ChromeDriver v114? The pipeline fails for v1.83.
  • Should we make the peer dependency on webdriverio explicitly ^8.14.0?
  • Want a separate PR to update dependencies? It looks like that was folded into Use WebdriverIOs driver setup mechanism #94 as well but I didn't include it to try to simplify the change.
  • Would you prefer to keep the ServiceCapability interface?

@christian-bromann christian-bromann force-pushed the main branch 4 times, most recently from a6c2fd4 to 4665af8 Compare February 13, 2024 07:12
@christian-bromann
Copy link
Contributor

Can we update the CI tests to run on VS Code v1.84 minimum? This should hopefully resolve the problem. I think we need to set the minimum VS Code version to the one that runs on Chromium 115 and make this a breaking change.

@seanpoulter
Copy link
Contributor Author

Will do.

I'm curious, if you did need to support older versions would you be able to keep wdio-chromedriver-service and it'd override the core implementation?

@christian-bromann
Copy link
Contributor

Yeah .. maybe we can include a section with some information about it, e.g. adding chromedriver to the package.json and add it as service. Not sure how straightforward it is.

@seanpoulter
Copy link
Contributor Author

Ah, 1.85 is looking for Chromedriver 114. The VS Code manifests confirm that it uses v118 in 1.86.0.

@christian-bromann
Copy link
Contributor

💚

Can we add some documentation about the versioning?

@seanpoulter
Copy link
Contributor Author

I've updated the docs. The pipeline failure is a timeout at line 20578.

@seanpoulter
Copy link
Contributor Author

This should close #101.

It no longer closes #97 (update deps). Let me know which deps and I'll get a PR up for that too.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for your efforts!

LGTM 👍

@christian-bromann christian-bromann merged commit b661258 into webdriverio-community:main Feb 15, 2024
17 of 18 checks passed
@wdio-bot
Copy link
Collaborator

Hey seanpoulter 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@christian-bromann
Copy link
Contributor

Released as part of v6.0.0!

@seanpoulter seanpoulter deleted the remove-wdio-chromedriver-service branch February 20, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants