-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WebdriverIOs driver setup mechanism #105
Use WebdriverIOs driver setup mechanism #105
Conversation
* `wdio-chromedriver-service` * `chromedriver` * `@types/chromedriver`
a6c2fd4
to
4665af8
Compare
Can we update the CI tests to run on VS Code v1.84 minimum? This should hopefully resolve the problem. I think we need to set the minimum VS Code version to the one that runs on Chromium 115 and make this a breaking change. |
Will do. I'm curious, if you did need to support older versions would you be able to keep |
Yeah .. maybe we can include a section with some information about it, e.g. adding |
Ah, 1.85 is looking for Chromedriver 114. The VS Code manifests confirm that it uses v118 in 1.86.0. |
💚 Can we add some documentation about the versioning? |
I've updated the docs. The pipeline failure is a timeout at line 20578. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for your efforts!
LGTM 👍
b661258
into
webdriverio-community:main
Hey seanpoulter 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Released as part of |
Context
This is my attempt to drive #94 ahead. I believe your branch was very close and mostly needed to set the
browserVersion
.Proposed Changes
chromedriver
andwdio-chromedriver-service
Questions
ServiceCapability
interface?