Use WebdriverIOs driver setup mechanism #94

christian-bromann · 2023-11-28T03:08:18Z

This patch will remove chromedriver and wdio-chromedriver-service in favor of WebdriverIOs own driver setup mechanism.

Note: this currently doesn't work yet as Chrome for testing started to release Chromedriver starting v115. VS Code however currently still relies on v114 for their latest VS Code release.

openscript · 2023-12-01T12:20:50Z

If I set up a new project via wdio/cli and running wdio config it doesn't add ts-node to my dependencies. Maybe the setup can add it to the package.json.

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'ts-node' imported from /workspaces/monorepo/project
    at new NodeError (node:internal/errors:405:5)
    at packageResolve (node:internal/modules/esm/resolve:887:9)
    at moduleResolve (node:internal/modules/esm/resolve:936:20)
    at defaultResolve (node:internal/modules/esm/resolve:1129:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:835:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:524:22)
    at initializeLoader (node:internal/process/esm_loader:75:58)
    at loadESM (node:internal/process/esm_loader:90:11) {
  code: 'ERR_MODULE_NOT_FOUND'
}

README.md

Co-authored-by: Sean Poulter <sean.poulter+gh@gmail.com>

mattseddon · 2024-02-01T21:25:28Z

@christian-bromann version 1.86.0 of VS Code shipped with version 118.0.5993.159 of Chromium. Would it be possible to make this change now?

christian-bromann · 2024-02-01T22:28:56Z

I haven't been able to make progress on this, if anyone wants to push it over the goal line I would appreciate it.

seanpoulter · 2024-02-05T21:39:28Z

You've got our eyes on it @christian-bromann. How can we help? I'd suggest splitting the changes to the docs/imports out into a small quick PR, and we can focus on the behaviour changes separately.

christian-bromann · 2024-02-06T17:46:10Z

I hope to be able to take a look at this sometime this week. If you like to take this one feel free.

seanpoulter · 2024-02-07T01:52:50Z

README.md


 #### `cachePath`

-Define a cache path to avoid re-downloading all bundles. This is useful for CI/CD to avoid re-downloading VSCode and Chromedriver for every testrun.
+Define a cache path to avoid re-downloading VS Code bundles. This is useful for CI/CD to avoid re-downloading VSCode and Chromedriver for every test run.


This is out of scope of this PR but would we want to try to normalize how we write VS Code/VSCode, and Chromedriver/ChromeDriver?

seanpoulter · 2024-02-11T03:48:03Z

package.json

    "yargs-parser": "^21.1.1"
  },
  "peerDependencies": {
-    "chromedriver": "latest",
    "webdriverio": "^8.0.0"


If I understand the blog post correctly, will this need to explicitly be ^8.14.0?

seanpoulter · 2024-02-11T13:01:25Z

src/launcher.ts

@@ -147,77 +137,24 @@ export default class VSCodeServiceLauncher extends ChromedriverServiceLauncher {
            throw new Error(`No key "${VSCODE_CAPABILITY_KEY}" found in caps`)
        }

-        if (versionsFileExist) {


Did you want to keep versions.txt at all @christian-bromann?

This looks really close. I think I've got it working/failing to start locally. That's a win because ChromeDriver on Linux on ARM isn't officially supported or downloaded.

If you can confirm how to handle the cache, and that you wanted to set the browserName = 'chrome' and browserVersion` to the version of Chromium bundled with VS Code, then I think I've got most of it done.

The pipeline still fails but I suspect it's because the code building the download links from Puppeteer only supports a 3 digit version number, not a 4 digit like we extract from the manifest. 🤔

Awesome, thanks for looking into this. Mind raising a new PR and we take it from there?

Caching for Chromedriver is handled by WebdriverIO. It doesn't cache the VS Code binary though which I am not sure will become a problem. I've implemented this with the idea in mind that test should work no matter if the user has an internet connection or not. That said, I am ok with moving forward without that feature and raise an issue to re-add it back.

I'll open a PR when I find a moment.

I believe we could keep with your original intent with the cache if we pivot to store the chromium version instead of chromium and let WebdriverIO handle Chromium/ChromeDriver.

Since I haven't got VS Code to open yet, would you happen to know if we'll want to use ChromeDriver or can we use Chrome for Testing to interact with VS Code? 🤔

Chrome for Testing and Chromedriver are different things. The first is the browser the other the driver. For automating VS Code we need Chromedriver and download the desired VS Code version. VS Code is an Electron application and "acts" as a browser here.

Seems like I don't have to touch the browserName anyways. 🎉

christian-bromann · 2024-02-13T16:50:07Z

Closing in favor of #105 ... thanks @seanpoulter 🙌

Use WebdriverIOs driver setup mechanism

8f24c8c

christian-bromann mentioned this pull request Dec 7, 2023

npm audit returns dependency vulnerabilities #97

Open

seanpoulter reviewed Jan 10, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

938940d

Co-authored-by: Sean Poulter <sean.poulter+gh@gmail.com>

julieg18 mentioned this pull request Feb 1, 2024

Attempt to fix e2e tests iterative/vscode-dvc#5260

Closed

This was referenced Feb 2, 2024

A service failed in the 'onPrepare' hook #101

Closed

[🐛 Bug]: wdio-vscode-service fails to download chrome driver for vscode version 1.86.0 webdriverio/webdriverio#12167

Closed

daphne-sfdc mentioned this pull request Feb 5, 2024

chore: downgrade VSCode to 1.85.2 for E2E tests forcedotcom/salesforcedx-vscode#5398

Merged

mattseddon mentioned this pull request Feb 6, 2024

Pin version of VS Code tested against to 1.85.2 for e2e tests iterative/vscode-dvc#5265

Merged

seanpoulter mentioned this pull request Feb 6, 2024

fix: Prevent "TypeError: object is not iterable" #102

Merged

seanpoulter reviewed Feb 7, 2024

View reviewed changes

This was referenced Feb 11, 2024

getText fails on Linux / Ubuntu #103

Closed

Update README.md and tsconfig.json #104

Merged

seanpoulter reviewed Feb 11, 2024

View reviewed changes

seanpoulter mentioned this pull request Feb 13, 2024

Use WebdriverIOs driver setup mechanism #105

Merged

christian-bromann force-pushed the main branch 4 times, most recently from a6c2fd4 to 4665af8 Compare February 13, 2024 07:12

christian-bromann closed this Feb 13, 2024

christian-bromann deleted the cb/driver-setup-update branch February 13, 2024 16:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use WebdriverIOs driver setup mechanism #94

Use WebdriverIOs driver setup mechanism #94

christian-bromann commented Nov 28, 2023 •

edited

Loading

openscript commented Dec 1, 2023

mattseddon commented Feb 1, 2024

christian-bromann commented Feb 1, 2024

seanpoulter commented Feb 5, 2024

christian-bromann commented Feb 6, 2024

seanpoulter Feb 7, 2024

christian-bromann Feb 7, 2024

seanpoulter Feb 11, 2024 •

edited

Loading

seanpoulter Feb 11, 2024

seanpoulter Feb 12, 2024

christian-bromann Feb 12, 2024

seanpoulter Feb 12, 2024

christian-bromann Feb 12, 2024

seanpoulter Feb 13, 2024

christian-bromann commented Feb 13, 2024

Use WebdriverIOs driver setup mechanism #94

Use WebdriverIOs driver setup mechanism #94

Conversation

christian-bromann commented Nov 28, 2023 • edited Loading

openscript commented Dec 1, 2023

mattseddon commented Feb 1, 2024

christian-bromann commented Feb 1, 2024

seanpoulter commented Feb 5, 2024

christian-bromann commented Feb 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanpoulter Feb 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christian-bromann commented Feb 13, 2024

christian-bromann commented Nov 28, 2023 •

edited

Loading

seanpoulter Feb 11, 2024 •

edited

Loading