Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing 299 #302

Closed
wants to merge 18 commits into from
Closed

Testing 299 #302

wants to merge 18 commits into from

Conversation

henrykironde
Copy link
Contributor

No description provided.

@@ -22,16 +20,18 @@ jobs:
fail-fast: false
matrix:
config:
- {os: macos-latest, r: 'release'}
Copy link
Contributor

@olivroy olivroy Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- {os: macos-latest, r: 'release'}

Looks like what you did actually worked for R-devel with the changes in 049f67c and 761423b (if I was not clear). ! I added a check for macOS just because it is the "standard" workflow, but it may be work for another time to figure this one out!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olivroy, let me try that R-devel and see, and we shall add the changes to the main PR after.

Copy link
Contributor

@olivroy olivroy Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, it seems that 049f67c and 761423b actually fixed the r-devel issue. (I edited my comment above to reflect this). macOS is also not currently tested on main branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants