-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi icon pack support 🐱 #23
Conversation
Hello, @JAFB321! Thanks for awesome PR! I want to mention the following things:
P.S. I've created a branch called |
Hi @win0err Thank you very much for the feedback! |
Thank you! If you have any questions — feel free to ask! |
Already implemented in #33; fell free to add new runners in different PRs |
Seems like the functionalities exists only in feature/v22 branch instead of master? |
Features:
Now you can go to the settings and select the pack in the combobox:


I don't have more cool icons, I just added a dancing parrot and funny walking chicken. But this changes make us able to add more icon packs in a easy way.
How to add more icon packs
3.- Then add the IconProvider preset

The
getIconProvider
function return an instance of IconProvider with the preset of each icon pack.Note that the IconProvider class now has the following params:
Enjoy!
Any feedback is welcome, I like your project and I can contribute to add more features if you want ! :)