-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/runner packs #33
Conversation
Thanks for your awesome work! Metronome looks very cool, feel free to add yourself here: https://github.com/win0err/gnome-runcat/blob/master/src/resources/ui/preferences.ui#L83 Ping me when the PR will be ready for review |
In my opinion, this does not make much sense because the settings are applied automatically and immediately |
I suggest the following plan:
|
I've merged #24 into Please, resolve conflicts and mark the PR as non-draft. |
Thank you for great work, @exincore! I'll add some features also and publish a new version in a month. |
Awesomee work! |
The commits are in v22 branch and not in main? |
Yes. That’s a development branch. |
I understand, however we are now on v23 - just wondering if there's anything needed to do to merge this back into master. I'll be more than happy to produce a cherry-picked/rebased PR of this feature against master.
…On Sun, Jun 18, 2023 at 03:00, Sergei Kolesnikov ***@***.***(mailto:On Sun, Jun 18, 2023 at 03:00, Sergei Kolesnikov <<a href=)> wrote:
> The commits are in v22 branch and not in main?
Yes. That’s a development branch.
You may clone the repo, checkout the branch, than run make install
—
Reply to this email directly, [view it on GitHub](#33 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADDYGEWV6VMHWCDJYCQQOGTXLX5DHANCNFSM6AAAAAARPURITU).
You are receiving this because you commented.Message ID: ***@***.***>
|
Runner Packs
RELIES UPON #24
What?
Why?
How?
panelMenuButton.js
loads different icon sets depending on user settingprefs.js
et al. has a enum selector for choosing the runner packruncat-metronome.mp4
To-do