Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/runner packs #33

Merged
merged 18 commits into from
Oct 31, 2022
Merged

Conversation

exincore
Copy link

@exincore exincore commented Oct 27, 2022

Runner Packs

RELIES UPON #24

What?
  • Other runner icons/animations can be selected
Why?
How?
  • panelMenuButton.js loads different icon sets depending on user setting
  • prefs.js et al. has a enum selector for choosing the runner pack
  • Brand new metronome runner, created by me!
runcat-metronome.mp4

Screenshot from 2022-10-26 22-41-22

To-do
  • Display runner thumbnail in settings menu and dropdown

@win0err win0err assigned win0err and unassigned win0err Oct 27, 2022
@win0err win0err added the enhancement New feature or request label Oct 27, 2022
@win0err
Copy link
Owner

win0err commented Oct 27, 2022

Thanks for your awesome work! Metronome looks very cool, feel free to add yourself here: https://github.com/win0err/gnome-runcat/blob/master/src/resources/ui/preferences.ui#L83

Ping me when the PR will be ready for review

@win0err
Copy link
Owner

win0err commented Oct 29, 2022

Display runner thumbnail in settings menu and dropdown

In my opinion, this does not make much sense because the settings are applied automatically and immediately

@win0err win0err changed the base branch from master to feature/v22 October 29, 2022 13:45
@win0err
Copy link
Owner

win0err commented Oct 29, 2022

I suggest the following plan:

  1. Merge animated idle (Feature/animated-sleeping #24) feature;
  2. Merge this feature.

@win0err
Copy link
Owner

win0err commented Oct 29, 2022

I've merged #24 into feature/v22 branch.

Please, resolve conflicts and mark the PR as non-draft.
PR looks good to me. I'm ready to merge it after resolving conflicts.

@exincore exincore marked this pull request as ready for review October 30, 2022 05:03
@win0err win0err merged commit 2225ed1 into win0err:feature/v22 Oct 31, 2022
@win0err
Copy link
Owner

win0err commented Oct 31, 2022

Thank you for great work, @exincore!

I'll add some features also and publish a new version in a month.

@JAFB321
Copy link

JAFB321 commented Oct 31, 2022

Awesomee work!

win0err pushed a commit that referenced this pull request Mar 15, 2023
win0err pushed a commit that referenced this pull request Mar 16, 2023
win0err pushed a commit that referenced this pull request Mar 26, 2023
@evanslify
Copy link

The commits are in v22 branch and not in main?

@win0err
Copy link
Owner

win0err commented Jun 17, 2023

The commits are in v22 branch and not in main?

Yes. That’s a development branch.
You may clone the repo, checkout the branch, than run make install

@evanslify
Copy link

evanslify commented Jun 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants