Add German translation for v22 #41
Conversation
The cat has a sleeping animation now
|
Missing translation for the line: Lines 68 to 70 in 86d8737 |
Yes, I know. I would need to know the context of "Runner pack" to translate it. |
Sorry, I just thought you have RunCat installed on your system. Here's the context: Screencast.from.2023-03-17.10-43-40.webm |
I would go with "Figur" as the translation in this context. |
|
I think it's ready to be merged. |
src/resources/ui/preferences.ui
Outdated
| @@ -80,7 +108,7 @@ | |||
| <object class="GtkAboutDialog" id="about-dialog"> | |||
| <property name="program-name">GNOME RunCat</property> | |||
| <property name="authors">Sergei Kolesnikov https://kolesnikov.se/</property> | |||
| <property name="artists">Sergei Kolesnikov, Takuto Nakamura</property> | |||
| <property name="artists">exincore, Sergei Kolesnikov, Takuto Nakamura, WebSnke</property> | |||
There was a problem hiding this comment.
Hello! While translating is an art, you may be more accurately credited as a translator with the "translator-credits" property.
The following line should work when inserted alongside the other credits.
<property name="translator-credits">WebSnke</property>There was a problem hiding this comment.
Thanks, I just pushed the suggestion.
There was a problem hiding this comment.
You did it wrong the second time.
a. #40 (comment)
b. #41 (comment)
Please, be more attentive
There was a problem hiding this comment.
Ok, I just changed it to "translator-credits".
There was a problem hiding this comment.
Please, fix linting (npm run lint --fix) and I'll merge the PR
There was a problem hiding this comment.
I think adding a command to update gettext to the main.yml file could resolve this issue.
There was a problem hiding this comment.
I'm sorry, check out the output of CI run: https://github.com/win0err/gnome-runcat/actions/runs/4541393529/jobs/8003501586?pr=41
It fails on message extraction. It means that there's a problem with translations that are not up-to-date. Please, try to update them: make translations
There was a problem hiding this comment.
It seems like you need to update some sort of ITS rule file to remove the warning.
There was a problem hiding this comment.
Are you serious? Why I should remove checks that I set up to check that translations are up-to-date and extension's code is well-formatted?
There was a problem hiding this comment.
I didn't suggest to remove the checks. LOL.
src/resources/ui/preferences.ui
Outdated
| </interface> |
There was a problem hiding this comment.
The newline seems to be automatically added after I remove it...
There was a problem hiding this comment.
Hi. I just wanted to ask what the state of this PR is. Are planing on merging it soon?
There was a problem hiding this comment.
Hi. I just wanted to ask what the state of this PR is. Are planing on merging it soon?
Nope, because PR is not ready to merge (All checks have failed)
There was a problem hiding this comment.
Hi. I just wanted to ask what the state of this PR is. Are planing on merging it soon?
Nope, because PR is not ready to merge (All checks have failed)
Ok, all checks have passed and this PR is now ready to be merged.
Hi. I just wanted to ask what the state of this PR is. Are planing on merging it soon?
Nope, because PR is not ready to merge (All checks have failed)
@win0err
All checks have passed now and this PR is ready to be merged.
No description provided.