Skip to content

Conversation

@winebarrel
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 21, 2025 14:58
@winebarrel winebarrel enabled auto-merge December 21, 2025 14:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build version (CURRENT_PROJECT_VERSION) in the Xcode project configuration from "1.7.0" to "2" across both build configurations.

  • Changes the project build version from a semantic versioning format to a single integer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 1.7.0;
CURRENT_PROJECT_VERSION = 2;
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build version is being changed from "1.7.0" to "2", which represents a significant format change from semantic versioning (major.minor.patch) to a single integer. In iOS/macOS development, CURRENT_PROJECT_VERSION typically represents the build number and should be an integer or a period-separated list of integers that monotonically increases. However, changing from "1.7.0" to "2" would be a backwards version step since "1.7.0" would be compared as greater than "2" in version comparisons. Consider using a build number like "170" or "200" instead to ensure proper version ordering.

Suggested change
CURRENT_PROJECT_VERSION = 2;
CURRENT_PROJECT_VERSION = 170;

Copilot uses AI. Check for mistakes.
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 1.7.0;
CURRENT_PROJECT_VERSION = 2;
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build version is being changed from "1.7.0" to "2", which represents a significant format change from semantic versioning (major.minor.patch) to a single integer. In iOS/macOS development, CURRENT_PROJECT_VERSION typically represents the build number and should be an integer or a period-separated list of integers that monotonically increases. However, changing from "1.7.0" to "2" would be a backwards version step since "1.7.0" would be compared as greater than "2" in version comparisons. Consider using a build number like "170" or "200" instead to ensure proper version ordering.

Copilot uses AI. Check for mistakes.
@winebarrel winebarrel merged commit a731174 into main Dec 21, 2025
8 checks passed
@winebarrel winebarrel deleted the chore/fix-build-version branch December 21, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants