-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Bump up build version #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -301,7 +301,7 @@ | |
| CODE_SIGN_ENTITLEMENTS = PagerCall/PagerCall.entitlements; | ||
| CODE_SIGN_STYLE = Automatic; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| CURRENT_PROJECT_VERSION = 1.7.0; | ||
| CURRENT_PROJECT_VERSION = 2; | ||
| DEAD_CODE_STRIPPING = YES; | ||
| DEVELOPMENT_ASSET_PATHS = ""; | ||
| ENABLE_APP_SANDBOX = YES; | ||
|
|
@@ -334,7 +334,7 @@ | |
| CODE_SIGN_ENTITLEMENTS = PagerCall/PagerCall.entitlements; | ||
| CODE_SIGN_STYLE = Automatic; | ||
| COMBINE_HIDPI_IMAGES = YES; | ||
| CURRENT_PROJECT_VERSION = 1.7.0; | ||
| CURRENT_PROJECT_VERSION = 2; | ||
|
||
| DEAD_CODE_STRIPPING = YES; | ||
| DEVELOPMENT_ASSET_PATHS = ""; | ||
| ENABLE_APP_SANDBOX = YES; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build version is being changed from "1.7.0" to "2", which represents a significant format change from semantic versioning (major.minor.patch) to a single integer. In iOS/macOS development, CURRENT_PROJECT_VERSION typically represents the build number and should be an integer or a period-separated list of integers that monotonically increases. However, changing from "1.7.0" to "2" would be a backwards version step since "1.7.0" would be compared as greater than "2" in version comparisons. Consider using a build number like "170" or "200" instead to ensure proper version ordering.