Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 #2435

Merged
merged 28 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
447b3dc
feat: create authentication identity input view
El-Fitz Dec 31, 2024
4e0db9b
chore: add tests & Localizable.strings
El-Fitz Jan 7, 2025
2aa3c65
chore: use L10n strings
El-Fitz Jan 8, 2025
82889b5
chore: update snapshots to use iPhone 14 iOS 17.5
El-Fitz Jan 10, 2025
5a4e462
fix: labeled text field UI
El-Fitz Jan 17, 2025
a0c8112
style: fix formatting
El-Fitz Jan 20, 2025
53d23a3
fix: add authentication UI tests to WireUIAll tests
El-Fitz Jan 20, 2025
4881fb0
refactor: extract static methods out of struct scope
El-Fitz Jan 20, 2025
6c806cc
fix: update TeamNameView snapshots following labelled field update
El-Fitz Jan 21, 2025
cc3441d
chore: fix typo in test class name
El-Fitz Jan 22, 2025
75c12dc
chore: misc requested changes, fixes & improvements
El-Fitz Jan 22, 2025
a5351ea
refactor: LabeledTextField free functions to computed vars
El-Fitz Jan 22, 2025
ffd02db
fix formatting, update snasphots
El-Fitz Jan 22, 2025
be10146
fix: typo
El-Fitz Jan 23, 2025
a0f4db3
chore: remove reference snapshots from another branch
El-Fitz Jan 23, 2025
98f111a
fix: remove line limit
El-Fitz Jan 24, 2025
168fd13
Merge branch 'develop' into feat/authentication-ui-identity-input
KaterinaWire Jan 27, 2025
e0c7ad4
feat: fix acc snapshots
KaterinaWire Jan 27, 2025
7b4f07b
feat: fix acc snapshots
KaterinaWire Jan 27, 2025
d5c1854
feat: clean up
KaterinaWire Jan 27, 2025
5d35b15
fix: swiftFormat
KaterinaWire Jan 27, 2025
4ef15e6
fix: swiftFormat
KaterinaWire Jan 27, 2025
e5b8a72
Merge branch 'develop' into feat/acc-authentication-ui-identity-input
KaterinaWire Jan 27, 2025
2b72968
feat: new snapshots
KaterinaWire Jan 27, 2025
ac2ef5b
feat: new snapshots
KaterinaWire Jan 27, 2025
cd1e972
feat: new snapshots
KaterinaWire Jan 27, 2025
aaab9c0
update snapshots
KaterinaWire Jan 28, 2025
2b178cc
update snapshots
KaterinaWire Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: fix formatting
El-Fitz committed Jan 24, 2025
commit a0c811200ca02a21882280749588d4577d74ae04
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@ public struct LabeledTextField: View {
.focused($isFocused)
.foregroundStyle(Self.labelColor(isEnabled: isEnabled))
.padding(.vertical, 12)
if !string.isEmpty && isEnabled {
if !string.isEmpty, isEnabled {
Button(action: {
string = ""
}, label: {
@@ -89,7 +89,7 @@ public struct LabeledTextField: View {
}

static func titleColor(isEnabled: Bool, isFocused: Bool) -> Color {
if isEnabled && isFocused {
if isEnabled, isFocused {
return ColorTheme.Base.onPrimaryVariant.color
}
if isEnabled {
@@ -113,7 +113,7 @@ public struct LabeledTextField: View {
}

static func labelBorderColor(isEnabled: Bool, isFocused: Bool) -> Color {
if isEnabled && isFocused {
if isEnabled, isFocused {
return ColorTheme.Base.onPrimaryVariant.color
}
if isEnabled {