Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 #2435

Merged
merged 28 commits into from
Jan 28, 2025

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Jan 27, 2025

TaskWPB-15221 [iOS] Implement new authentication flow views - Identification View

Issue

In this PR I updated a UI according to a new design changes (@El-Fitz I hope you don't mind)
And updated the UI to support large fonts:

  1. To ensure the main text grows vertically with .fixedSize(horizontal: false, vertical: true)
  2. Shrink the text for the email text field header with .minimumScaleFactor(0.8)

Unfortunately, we can't do much with the placeholder except make it a custom text element.

Testing

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 27, 2025
@KaterinaWire KaterinaWire changed the title Feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 Jan 27, 2025
@KaterinaWire KaterinaWire requested review from El-Fitz, jullianm and samwyndham and removed request for jullianm January 27, 2025 14:21
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Test Results

  1 files   10 suites   32s ⏱️
107 tests 106 ✅ 1 💤 0 ❌
108 runs  107 ✅ 1 💤 0 ❌

Results for commit 2b178cc.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 27, 2025

Datadog Report

Branch report: feat/acc-authentication-ui-identity-input
Commit report: 01e5eed
Test service: wire-ios-mono

✅ 0 Failed, 84 Passed, 1 Skipped, 14.97s Total Time

Base automatically changed from feat/authentication-ui-identity-input to develop January 27, 2025 15:32
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KaterinaWire KaterinaWire added this pull request to the merge queue Jan 28, 2025
Merged via the queue into develop with commit 237f40d Jan 28, 2025
10 of 11 checks passed
@KaterinaWire KaterinaWire deleted the feat/acc-authentication-ui-identity-input branch January 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: scale Enterprise Readiness Initiatives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants