-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 #2435
feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 #2435
Conversation
Test Results 1 files 10 suites 32s ⏱️ Results for commit 2b178cc. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 1 Skipped, 14.97s Total Time |
WireUI/Sources/WireReusableUIComponents/LabeledTextField/LabeledTextField.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Issue
In this PR I updated a UI according to a new design changes (@El-Fitz I hope you don't mind)
And updated the UI to support large fonts:
.fixedSize(horizontal: false, vertical: true)
.minimumScaleFactor(0.8)
Unfortunately, we can't do much with the placeholder except make it a custom text element.
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: