-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Add accessibility support to the AuthenticationIdentityInputView - WPB-15221 #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KaterinaWire
merged 28 commits into
develop
from
feat/acc-authentication-ui-identity-input
Jan 28, 2025
Merged
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
447b3dc
feat: create authentication identity input view
El-Fitz 4e0db9b
chore: add tests & Localizable.strings
El-Fitz 2aa3c65
chore: use L10n strings
El-Fitz 82889b5
chore: update snapshots to use iPhone 14 iOS 17.5
El-Fitz 5a4e462
fix: labeled text field UI
El-Fitz a0c8112
style: fix formatting
El-Fitz 53d23a3
fix: add authentication UI tests to WireUIAll tests
El-Fitz 4881fb0
refactor: extract static methods out of struct scope
El-Fitz 6c806cc
fix: update TeamNameView snapshots following labelled field update
El-Fitz cc3441d
chore: fix typo in test class name
El-Fitz 75c12dc
chore: misc requested changes, fixes & improvements
El-Fitz a5351ea
refactor: LabeledTextField free functions to computed vars
El-Fitz ffd02db
fix formatting, update snasphots
El-Fitz be10146
fix: typo
El-Fitz a0f4db3
chore: remove reference snapshots from another branch
El-Fitz 98f111a
fix: remove line limit
El-Fitz 168fd13
Merge branch 'develop' into feat/authentication-ui-identity-input
KaterinaWire e0c7ad4
feat: fix acc snapshots
KaterinaWire 7b4f07b
feat: fix acc snapshots
KaterinaWire d5c1854
feat: clean up
KaterinaWire 5d35b15
fix: swiftFormat
KaterinaWire 4ef15e6
fix: swiftFormat
KaterinaWire e5b8a72
Merge branch 'develop' into feat/acc-authentication-ui-identity-input
KaterinaWire 2b72968
feat: new snapshots
KaterinaWire ac2ef5b
feat: new snapshots
KaterinaWire cd1e972
feat: new snapshots
KaterinaWire aaab9c0
update snapshots
KaterinaWire 2b178cc
update snapshots
KaterinaWire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...nceImages/AuthenticationIdentityInputViewTests/testColorSchemeVariants.dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ceImages/AuthenticationIdentityInputViewTests/testColorSchemeVariants.light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...AuthenticationIdentityInputViewTests/testDynamicTypeVariants.accessibility1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...AuthenticationIdentityInputViewTests/testDynamicTypeVariants.accessibility2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...AuthenticationIdentityInputViewTests/testDynamicTypeVariants.accessibility3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...AuthenticationIdentityInputViewTests/testDynamicTypeVariants.accessibility4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...AuthenticationIdentityInputViewTests/testDynamicTypeVariants.accessibility5.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ceImages/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.large.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...eImages/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.medium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ceImages/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...eImages/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.xLarge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...eImages/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.xSmall.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...Images/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.xxLarge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...mages/AuthenticationIdentityInputViewTests/testDynamicTypeVariants.xxxLarge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.