fix: remove stage-specific .env vars; pass via command during CI instead

.github/workflows/delete-stack-on-pr-close.yaml

@@ -28,5 +28,5 @@ jobs:
         aws_secret_access_key = ${{ secrets.AWS_SECRET_ACCESS_KEY }}" > ~/.aws/credentials
 
     - name: Delete PR preview stack
-      run: SERVERLESS_SERVICE_SUFFIX=${{ github.head_ref }} npm run remove-stack:dev
+      run: SERVERLESS_SERVICE_SUFFIX=-${{ github.head_ref }} npm run remove-stack:dev
 

.github/workflows/on-pr.yaml

@@ -24,17 +24,13 @@ jobs:
       uses: actions/setup-node@v1
       with:
         node-version: 12.x
-    - name: lsla
-      run: ls -la && ls -la packages && ls -la packages/ui
+
     - name: Install package
       run: |
         (npm ci && npm audit --audit-level high && npm test) & \
         (cd packages/ui && npm ci && npm audit --audit-level high && npm test) & \
         (cd packages/api && npm ci && npm audit --audit-level high && npm test)
 
-    - name: Copy example.env.development to .env
-      run: cp example.env.development .env
-
     - name: Deploy to sandboxed stack
       id: deploy_to_sandboxed_stack
       run: |
@@ -44,7 +40,7 @@ jobs:
         aws_secret_access_key = ${{ secrets.AWS_SECRET_ACCESS_KEY }}" > ~/.aws/credentials
         # TODO: How to also get the PR origin repo if it's coming from an external contributor
         # See: env.GITHUB_REF, env.GITHUB_HEAD_REF, GITHUB_BASE_REF https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
-        NODE_ENV=production SERVERLESS_SERVICE_SUFFIX=-${{ github.head_ref }} npm run deploy:dev
+        NODE_ENV=production ALARMS_NOTIFICATION_EMAIL=alert@example.com SERVERLESS_SERVICE_SUFFIX=-${{ github.head_ref }} npm run deploy:dev
         WEBSITE_URL=https://$(grep -o 'DefaultDomain": "[^"]*' ./stack-outputs.json | grep -o '[^"]*$')
         echo "::set-output name=websiteUrl::$WEBSITE_URL"
     

.github/workflows/on-push-to-master.yaml

@@ -22,16 +22,13 @@ jobs:
         (cd packages/ui && npm ci && npm audit --audit-level high && npm test) & \
         (cd packages/api && npm ci && npm audit --audit-level high && npm test)
 
-    - name: Copy example.env.development to .env
-      run: cp example.env.development .env
-
     - name: Deploy to staging
       run: |
         mkdir ~/.aws
         echo "[myapp_staging]
         aws_access_key_id = ${{ secrets.AWS_ACCESS_KEY_ID }}
         aws_secret_access_key = ${{ secrets.AWS_SECRET_ACCESS_KEY }}" > ~/.aws/credentials
-        NODE_ENV=production SERVERLESS_SERVICE_SUFFIX='' npm run deploy:staging
+        NODE_ENV=production npm run deploy:staging
 
     # TODO: Additional end-to-end tests
 

README.md

@@ -29,7 +29,7 @@ Make a copy of the `example.env.development` file:
 cp example.env.development .env.development
 ```
 
-Modify the values in your `.env.development` file.
+Modify the values in your `.env.development` file. If you're using a shared developer account, you should set `SERVERLESS_SERVICE_SUFFIX=-brett`, ensuring the value you specify is unique and not used by other developers on your team.
 
 Run `npm run deploy:dev` to deploy to your dev account.
 

example.env.development

@@ -1,2 +1,2 @@
-SERVERLESS_SERVICE_SUFFIX=-myname
+SERVERLESS_SERVICE_SUFFIX=
 ALARMS_NOTIFICATION_EMAIL=alert@example.com

packages/ui/package.json

@@ -19,9 +19,8 @@
     "typeface-roboto": "0.0.75"
   },
   "scripts": {
-    "start-cloud-api": "npm run cp-stack-outputs && react-scripts start",
-    "start": "npm run cp-stack-outputs && react-scripts start",
-    "cp-stack-outputs": "echo 1 || cp ../../stack-outputs.json ./src",
+    "start-cloud-api": "react-scripts start",
+    "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "react-scripts test",
     "eject": "react-scripts eject",