wis2download test and wis2box downloader commands to manage topics #693
Conversation
|
@david-i-berry this (currently in draft) PR is used to test your wis2downloader-PR wmo-im/wis2downloader#18 |
add latest commits to gts-headers-mapping PR
| fh.write('DOWNLOAD_BROKER_USERNAME=everyone\n') | ||
| fh.write('DOWNLOAD_BROKER_PASSWORD=everyone\n') | ||
| fh.write('# download transport mechanism (tcp or websockets)\n') | ||
| fh.write('DOWNLOAD_BROKER_TRANSPORT=tcp\n') |
There was a problem hiding this comment.
Why tcp and not websockets by default? Port 8883 is often blocked.
There was a problem hiding this comment.
ok I will make websocker port=443 the default
| def remove_subscription(ctx, topic): | ||
| """remove a subscription""" | ||
|
|
||
| topic = topic.replace('%23', '#') |
There was a problem hiding this comment.
Is this the correct way around?
| """remove a subscription""" | ||
|
|
||
| topic = topic.replace('%23', '#') | ||
| topic = topic.replace('%2B', '+') |
There was a problem hiding this comment.
Is this the correct way around?
| @@ -358,6 +358,17 @@ def create_wis2box_env(config_dir: str) -> None: | |||
| fh.write('MINIO_NOTIFY_MQTT_TOPIC_WIS2BOX=wis2box/storage\n') | |||
| fh.write('MINIO_NOTIFY_MQTT_QOS_WIS2BOX=1\n') | |||
| fh.write('\n') | |||
| # downloader settings | |||
There was a problem hiding this comment.
What role do the ENV variables have? Should they not be used here?
There was a problem hiding this comment.
I write the default values to the wis2box.env to make it easier for the users to edit them
|
closing, changes have been merged into gts-headers-mapping branch to be reviewed in PR 691 |
rename 'wis2-downloader' to 'wis2downloader' for consistency in all files and documentation
update test to enable subscribe to self and add test with count check per topic
add 'wis2box downloader' commands to manage subscriptions
improve downloader dashboard and cleanup old dashboards