feat: remove registration store for passkeys #101
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolodamico
requested review from
aurel-fr,
murph and
thomas-waite
as code owners
aurel-fr
approved these changes
Sep 6, 2025
| webauthn_credential, | ||
| .. | ||
| } => ExportedFactorKind::Passkey { | ||
| credential_id: serde_plain::to_string(webauthn_credential.cred_id()) |
Contributor
There was a problem hiding this comment.
Sligthly confused by the comment below saying credential_id is base64 encoded, but this is not the case here?
Contributor
Author
There was a problem hiding this comment.
It is base64 encoded, CredentialId is base64 encoded in its serialization implementation. We use serde_plain to explicitly use the existing serializing logic.
https://github.com/kanidm/webauthn-rs/blob/master/webauthn-rs-core/src/interface.rs#L244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops storing the
registrationobject in the serialized metadata. This reduces the surface area to only allow registration objects once.