Fixes #734: make noise a lazy import in datasets module#858
Open
brendancol wants to merge 1 commit intomasterfrom
Open
Fixes #734: make noise a lazy import in datasets module#858brendancol wants to merge 1 commit intomasterfrom
brendancol wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import noisefrom top-level inxrspatial/datasets/__init__.pyto insidemake_terrain(), guarded by try/exceptfrom xrspatial.datasets import get_datawould fail withModuleNotFoundError: No module named 'noise'on a freshpip install xarray-spatialsincenoiseis only in[options.extras_require] testsnoise, andmake_terrain()raises a clearImportErrorwith install instructionsTest plan
xrspatial.datasetsimports successfully withoutnoiseinstalledmake_terrain()works whennoiseis installedmake_terrain()gives a clear error whennoiseis missing:ImportError: make_terrain requires the 'noise' package: pip install noise