Skip to content

Fixes #734: make noise a lazy import in datasets module #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendancol wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

Fixes #734: make noise a lazy import in datasets module #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion xrspatial/datasets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
da = None

import datashader as ds
import noise
import numpy as np
import pandas as pd
import xarray as xr
Expand Down Expand Up @@ -81,6 +80,13 @@ def make_terrain(
2D array of generated terrain values.
"""

try:
import noise
except ImportError:
raise ImportError(
"make_terrain requires the 'noise' package: pip install noise"
)

if da is None:
raise Exception("make terrain requires dask.Array (pip install dask)")

Expand Down