-
-
Notifications
You must be signed in to change notification settings - Fork 486
Auto-update rendergraph to v2.0.0 #8450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the rendergraph package to version v2.0.0. While the version and hash have been correctly added, this is a major version update that includes breaking changes. The package's build script (on_install function) has not been updated to account for these changes, which will lead to build failures. I've left a critical comment detailing the necessary changes to the build script to support v2.0.0.
|
|
||
| set_urls("https://github.com/DragonJoker/RenderGraph/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/DragonJoker/RenderGraph.git") | ||
| add_versions("v2.0.0", "9ab5bf4ef16fac2bec8633b1634843c97e3e244a556be62c942348e2462d0888") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates RenderGraph to v2.0.0, which is a major version with breaking changes. The current build script in on_install will fail for this new version and needs to be updated.
Specifically:
- The source directory has been renamed from
sourcetosrc(affects line 28). - For static builds on Windows, the preprocessor macro has changed from
CRG_BUILD_STATICtoCRG_STATIC_DEFINE(affects line 34).
To fix this, you'll need to make the on_install function aware of the version, for example by using package:version():ge("2.0.0") to conditionally set the source directory and the preprocessor define. Without these changes, the package will be broken for v2.0.0.
New version of rendergraph detected (package version: v1.4.1, last github version: v2.0.0)