Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 22, 2025

New version of rendergraph detected (package version: v1.4.1, last github version: v2.0.0)

@waruqi waruqi added the auto-update Automatic update label Oct 22, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automatically updates the rendergraph package to its latest version, v2.0.0. This ensures that the project can leverage the most recent features, performance improvements, and bug fixes provided by the updated library, maintaining compatibility and access to cutting-edge rendering capabilities.

Highlights

  • RenderGraph Version Update: The rendergraph package definition has been updated to include version v2.0.0.
  • Xmake Configuration: The xmake.lua file for the rendergraph package now registers v2.0.0 with its corresponding commit hash.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the rendergraph package to version v2.0.0. While the version and hash have been correctly added, this is a major version update that includes breaking changes. The package's build script (on_install function) has not been updated to account for these changes, which will lead to build failures. I've left a critical comment detailing the necessary changes to the build script to support v2.0.0.


set_urls("https://github.com/DragonJoker/RenderGraph/archive/refs/tags/$(version).tar.gz",
"https://github.com/DragonJoker/RenderGraph.git")
add_versions("v2.0.0", "9ab5bf4ef16fac2bec8633b1634843c97e3e244a556be62c942348e2462d0888")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR updates RenderGraph to v2.0.0, which is a major version with breaking changes. The current build script in on_install will fail for this new version and needs to be updated.

Specifically:

  • The source directory has been renamed from source to src (affects line 28).
  • For static builds on Windows, the preprocessor macro has changed from CRG_BUILD_STATIC to CRG_STATIC_DEFINE (affects line 34).

To fix this, you'll need to make the on_install function aware of the version, for example by using package:version():ge("2.0.0") to conditionally set the source directory and the preprocessor define. Without these changes, the package will be broken for v2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant