Skip to content

Auto-update rendergraph to v2.0.0 #8450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Auto-update rendergraph to v2.0.0 #8450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/r/rendergraph/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("rendergraph")

set_urls("https://github.com/DragonJoker/RenderGraph/archive/refs/tags/$(version).tar.gz",
"https://github.com/DragonJoker/RenderGraph.git")
add_versions("v2.0.0", "9ab5bf4ef16fac2bec8633b1634843c97e3e244a556be62c942348e2462d0888")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR updates RenderGraph to v2.0.0, which is a major version with breaking changes. The current build script in on_install will fail for this new version and needs to be updated.

Specifically:

  • The source directory has been renamed from source to src (affects line 28).
  • For static builds on Windows, the preprocessor macro has changed from CRG_BUILD_STATIC to CRG_STATIC_DEFINE (affects line 34).

To fix this, you'll need to make the on_install function aware of the version, for example by using package:version():ge("2.0.0") to conditionally set the source directory and the preprocessor define. Without these changes, the package will be broken for v2.0.0.

add_versions("v1.4.1", "7096a6384165f98ec3fab995deba10523b42a4f170f9ad9473107bc03eb50a3d")
add_versions("v1.4.0", "0009eac85885231069f7ba644d22a801e71505cc")
add_versions("v1.3.0", "b9c68b6949c7b60ffb49f9b9997432aac5baec69")
Expand Down
Loading