Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dispatching to be handled inside application #112

Merged
merged 5 commits into from
May 18, 2024
Merged

Refactor dispatching to be handled inside application #112

merged 5 commits into from
May 18, 2024

Conversation

thekid
Copy link
Member

@thekid thekid commented Apr 21, 2024

This pull request simplifies the handling of internal redirects, called dispatches:

  • Now handled inside Application::service() instead of needing the Routing::$top boolean
  • Removes the Dispatch class
  • No longer uses a mix of return and yield but yields dispatches with the dispatch key.

@thekid thekid merged commit f460e00 into master May 18, 2024
20 checks passed
@thekid thekid deleted the refactor/dispatch-to-app branch May 18, 2024 06:06
@thekid thekid mentioned this pull request May 18, 2024
Merged
thekid added a commit that referenced this pull request May 18, 2024
@thekid
Merge from HEAD after #112 is merged
c43d58d
@thekid thekid mentioned this pull request May 18, 2024
Closed
@thekid
Copy link
Member Author

thekid commented May 20, 2024

Released in https://github.com/xp-forge/web/releases/tag/v4.2.0

thekid added a commit that referenced this pull request Sep 8, 2024
@thekid
Remove unused code, dispatch handling is now done in web.Application
5e71388 
See PR #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thekid