feat(ci): Add task for package integration tests.

[quinntaylormitchell]

Description

This PR introduces the command task tests:integration:package, which runs uv run pytest -m package under the hood.

PR dependencies

This PR depends on the following being merged:

• feat(integration-tests): Add fixtures and tests for starting and stopping CLP packages. #1437

Checklist

• The PR satisfies the contribution guidelines.
• This is a breaking change and that has been indicated in the PR title, OR this isn't a
  breaking change.
• Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Ran the following command:

task tests:integration:package

Both the clp-json and clp-text tests passed.

Summary by CodeRabbit

• Tests

  • Added a new package-focused integration test task and integrated it into the default test workflow.
  • Provides an isolated test path to run package-related integration tests.

• Refactor

  • Reorganized core integration test path for clearer separation and explicit dependencies.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Added a new package integration test task and updated existing tasks in taskfiles/tests/integration.yaml: the default task now depends on package, and the core task was refactored to use an explicit dir and a deps entry.

Changes

Cohort / File(s)	Change Summary
Integration test tasks taskfiles/tests/integration.yaml	Added a package integration test task (sets CLP_BUILD_DIR, CLP_CORE_BINS_DIR, CLP_PACKAGE_DIR; dir set to integration tests; deps: ["::package"]; command uv run pytest -m package). Updated default task to include package in its deps. Refactored core task to use explicit dir and deps: ["::core"].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review package task env vars and working directory for correctness.
• Verify deps references (::package, ::core) resolve to intended tasks.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a new integration test task for package testing in the CI configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b9877c and 818d767.

📒 Files selected for processing (1)

• taskfiles/tests/integration.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (8)

📓 Common learnings

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1100
File: integration-tests/tests/fixtures/integration_test_logs.py:54-56
Timestamp: 2025-08-17T16:10:38.722Z
Learning: For PR #1100 (feat(integration-tests): Add CLP package integration tests boilerplate), do not raise cache weakness problems related to the pytest cache implementation in the integration test logs fixtures.

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1100
File: integration-tests/pyproject.toml:11-13
Timestamp: 2025-08-16T10:24:29.316Z
Learning: In the CLP project's integration-tests directory, the integration tests package is not intended to be shipped or distributed - only the tests are leveraged for local testing purposes, so console script entry points should not be included in pyproject.toml.

Learnt from: junhaoliao
Repo: y-scope/clp PR: 0
File: :0-0
Timestamp: 2025-10-22T21:02:31.113Z
Learning: Repository y-scope/clp: Maintain deterministic CI/builds for Rust; add a check to verify Cargo.lock is in sync with Cargo.toml without updating dependencies (non-mutating verification in clp-rust-checks workflow).

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1335
File: taskfiles/docker-images.yaml:15-15
Timestamp: 2025-09-25T19:26:32.436Z
Learning: In the CLP project's Taskfile, the `:package` task creates the G_PACKAGE_BUILD_DIR directory structure, so any task that depends on `:package` (like `docker-images:package`) can safely assume this directory exists without needing additional mkdir commands.

📚 Learning: 2025-08-16T10:24:29.316Z

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1100
File: integration-tests/pyproject.toml:11-13
Timestamp: 2025-08-16T10:24:29.316Z
Learning: In the CLP project's integration-tests directory, the integration tests package is not intended to be shipped or distributed - only the tests are leveraged for local testing purposes, so console script entry points should not be included in pyproject.toml.

Applied to files:

• taskfiles/tests/integration.yaml

📚 Learning: 2025-09-25T19:26:32.436Z

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1335
File: taskfiles/docker-images.yaml:15-15
Timestamp: 2025-09-25T19:26:32.436Z
Learning: In the CLP project's Taskfile, the `:package` task creates the G_PACKAGE_BUILD_DIR directory structure, so any task that depends on `:package` (like `docker-images:package`) can safely assume this directory exists without needing additional mkdir commands.

Applied to files:

• taskfiles/tests/integration.yaml

📚 Learning: 2025-08-17T16:10:38.722Z

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1100
File: integration-tests/tests/fixtures/integration_test_logs.py:54-56
Timestamp: 2025-08-17T16:10:38.722Z
Learning: For PR #1100 (feat(integration-tests): Add CLP package integration tests boilerplate), do not raise cache weakness problems related to the pytest cache implementation in the integration test logs fixtures.

Applied to files:

• taskfiles/tests/integration.yaml

📚 Learning: 2025-10-13T03:32:19.293Z

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1414
File: tools/docker-images/clp-package/Dockerfile:20-24
Timestamp: 2025-10-13T03:32:19.293Z
Learning: In the clp repository's Dockerfiles (e.g., tools/docker-images/clp-package/Dockerfile), ENV directives should be split into separate lines for readability rather than consolidated to reduce layer count. This is especially true for PATH modifications, as agreed upon in PR #1166. Later ENV settings may depend on earlier ones (e.g., referencing CLP_HOME).

Applied to files:

• taskfiles/tests/integration.yaml

📚 Learning: 2025-07-07T17:41:15.655Z

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:27-32
Timestamp: 2025-07-07T17:41:15.655Z
Learning: In CLP installation scripts, consistency across platform scripts is prioritized over defensive programming improvements. For example, when extracting Task binaries with tar in `install-prebuilt-packages.sh`, the extraction pattern should remain consistent with other platform scripts rather than adding defensive flags like `--strip-components=1` to handle potential tarball layout changes.

Applied to files:

• taskfiles/tests/integration.yaml

📚 Learning: 2025-10-20T21:05:30.417Z

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1413
File: tools/docker-images/clp-package/Dockerfile:22-24
Timestamp: 2025-10-20T21:05:30.417Z
Learning: In the clp repository's Dockerfiles, ENV directives should be consolidated into multi-line ENV statements when possible to reduce image layers. ENV statements should only be split into separate commands when consolidation is not possible due to dependencies (e.g., when later variables must reference earlier ones that need to be set first, or when PATH must be modified sequentially).

Applied to files:

• taskfiles/tests/integration.yaml

📚 Learning: 2025-08-09T04:07:27.083Z

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1156
File: components/core/CMakeLists.txt:772-772
Timestamp: 2025-08-09T04:07:27.083Z
Learning: In the CLP project's CMakeLists.txt, when reviewing changes related to the ${zstd_TARGET} variable usage in test linking, the team is planning a refactoring PR to improve this mechanism. Guards for undefined target variables should be deferred to that separate PR rather than being added in focused dependency migration PRs.

Applied to files:

• taskfiles/tests/integration.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: ubuntu-jammy-static-linked-bins
• GitHub Check: ubuntu-jammy-dynamic-linked-bins
• GitHub Check: centos-stream-9-dynamic-linked-bins
• GitHub Check: centos-stream-9-static-linked-bins
• GitHub Check: manylinux_2_28-x86_64-static-linked-bins
• GitHub Check: manylinux_2_28-x86_64-dynamic-linked-bins
• GitHub Check: rust-checks
• GitHub Check: lint-check (ubuntu-24.04)
• GitHub Check: build-macos (macos-15, false)
• GitHub Check: build-macos (macos-15, true)
• GitHub Check: build (ubuntu-24.04)

🔇 Additional comments (3)

taskfiles/tests/integration.yaml (3)

11-11: Default task updated to include package integration tests.

The new dependency has been properly added to the default task, ensuring package tests run as part of the standard test suite.

---

23-24: Core task refactored with consistent attribute ordering and cleaner deps syntax.

The refactoring follows the taskfile conventions with proper attribute ordering (env → dir → deps → cmd) and uses the cleaner ["::core"] syntax for consistency across the file.

---

31-38: Package integration test task properly structured and consistent with existing patterns.

The new package task mirrors the core task structure with:

• Identical environment variables (CLP_BUILD_DIR, CLP_CORE_BINS_DIR, CLP_PACKAGE_DIR)
• Correct working directory pointing to integration tests
• Clean, consistent deps: ["::package"] syntax
• Proper pytest command with package marker

All previous review feedback has been incorporated and the implementation follows taskfile conventions.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[junhaoliao]

for the tile, how about:

feat(ci): Add task for package integration test.

[junhaoliao]

just curious, since we're not passing any parameters to ::package, why don't we just write it as

Suggested change

	deps:
	- task: "::package"
	deps: ["::package"]

(i don't know much about the background but i also see the other deps in this taskfile use a similar syntax

[quinntaylormitchell]

I was following the syntax from the other deps; @Bill-hbrhbr what do you think?

[Bill-hbrhbr]

I don't have a strong opinion, but what Junhao's suggesting is cleaner.
Let's just be consistent within this file. So if you update this spot, make sure to update the core task as well.

[Bill-hbrhbr]

Actually thought this PR could fit right into the dev docs PR. But I'm not against breaking it up. So commenting for future considerations.