Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecation warnings for rawurlencode() and strpos() (#380) #383

Closed
wants to merge 9 commits into from
Closed

Conversation

g41797
Copy link

@g41797 g41797 commented Dec 29, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #380

"Deprecated" warning now showed for trim(), but it should be fixed in UrlManager.php
(another repo)

devenv:

  • PhpStorm 2023.3.1
  • PHP 8.3.1
  • Xdebug v3.3.1

Copy link

what-the-diff bot commented Dec 29, 2023

PR Summary

  • Improved Null Handling in 'OAuth1.php'
    In the file 'OAuth1.php', a series of changes have been made to ensure the system does not encounter unexpected problems if some values are missing or undefined. This involves using a null coalescing operator to flag certain items as empty strings if they're not present. The improved handling includes:
    • The URL
    • The method
    • The result of http_build_query
    • The consumer secret
    • The token secret

This results in a more robust behavior when these values aren't provided, reducing the risk of system errors and promoting smoother system operation overall.

@g41797 g41797 mentioned this pull request Dec 29, 2023
src/OAuth1.php Outdated Show resolved Hide resolved
src/OAuth1.php Outdated Show resolved Hide resolved
@g41797 g41797 requested a review from samdark January 1, 2024 14:00
src/OAuth1.php Outdated Show resolved Hide resolved
@samdark
Copy link
Member

samdark commented Jan 2, 2024

@g41797 do you want to fix the rest of compatibility issues? See tests failing.

@g41797
Copy link
Author

g41797 commented Jan 2, 2024

"Deprecated" warning (showed for trim()) are fixed by PR#20090

@samdark
Copy link
Member

samdark commented Jan 3, 2024

Merged that one.

@g41797 g41797 closed this by deleting the head repository May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants