Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecation warnings for trim() [PHP8.3] #20090

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Get rid of deprecation warnings for trim() [PHP8.3] #20090

merged 1 commit into from
Jan 3, 2024

Conversation

g41797
Copy link
Contributor

@g41797 g41797 commented Jan 3, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues Issue:Fix tests for 8.3, PR:Fix warnings

Copy link

what-the-diff bot commented Jan 3, 2024

PR Summary

  • Improved Code Robustness in UrlManager.php
    Made an important adjustment to ensure our software handles unexpected situations more gracefully. The change specifically targets how we extract specific parameters from a URL route. Simply put, we've made the system safer, avoiding potential crashes or bugs that could have come up when a parameter was missing. The software is now more robust and resilient to different scenarios.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dffb4c7) 48.02% compared to head (567e010) 48.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20090   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files         445      445           
  Lines       43890    43890           
=======================================
  Hits        21078    21078           
  Misses      22812    22812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added the php8 label Jan 3, 2024
@samdark samdark added this to the 2.0.50 milestone Jan 3, 2024
@samdark samdark merged commit c7b4b1d into yiisoft:master Jan 3, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants