Ozone prototype: #4311
Ozone prototype: #4311
Conversation
y4vor
force-pushed
the
ozone_prototyp_m114
branch
4 times, most recently
from
d3d0415 to
2e92f91
Compare
export USE_RBE=1 cobalt/build/gn.py -p linux-cobalt-x64x11 -C devel --no-check --override-args autoninja -C out/linux-cobalt-x64x11_devel/ content_shell content_shell --single-process --ozone-platform=starboard https://www.youtube.com/tv
y4vor
force-pushed
the
ozone_prototyp_m114
branch
from
2e92f91 to
8379942
Compare
| #if 0 | ||
| bool res = gpu_memory_buffer_support_->GetNativeGpuMemoryBufferType() != | ||
| gfx::EMPTY_BUFFER && | ||
| IsNativeGpuMemoryBufferConfiguration(format, usage); | ||
|
|
||
| return res; | ||
| #endif |
There was a problem hiding this comment.
This is probably needed/happening because we are taking
the IS_LINUX path in [1] - we should add an IS_STARBOARD
entry there (//gpu is a low level folder, like //base
or //media, so can know about "starboard").
| // hack | ||
| fallback_modes_.clear(); | ||
| fallback_modes_.push_back(gpu::GpuMode::HARDWARE_GL); | ||
|
|
There was a problem hiding this comment.
This might be needed because of l.553 -- we should be taking
the #else in l.551 (to be confirmed), and we end up using
vulkan for some reason. There is a build flag to enable/disable
vulkan [1] and this is probably enabled because it thinks we
are on Linux [2] (and we should force disable it for is_starboard).
[1] https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/main:content/browser/gpu/gpu_data_manager_impl_private.cc;l=402-416?q=vulkanallowed&ss=h%2Flbshell-internal%2Fcobalt_src%2F%2B%2Frefs%2Fheads%2Fmain&start=1
[2] https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/main:gpu/vulkan/features.gni;l=11?q=vulkan%20file:%5C.gni&ss=h%2Flbshell-internal%2Fcobalt_src%2F%2B%2Frefs%2Fheads%2Fmain
There was a problem hiding this comment.
Maybe #4361 will help removing this delta.
export USE_RBE=1
cobalt/build/gn.py -p linux-cobalt-x64x11 -C devel --no-check --override-args autoninja -C out/linux-cobalt-x64x11_devel/ content_shell content_shell --single-process --ozone-platform=starboard https://www.youtube.com/tv