Disable Vulkan build when is_starboard is defined #4361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulkan is a new rendering (and presentation, and more) API intended to replace E/GL(ES). Starboard doesn't define it and it's likely unsupported by partners (and even if it is, the status would be unknown and by experience not ready). This CL/PR disables building it when starboard is defined. On dependencies, //gpu is a low level folder (like //base) so it can depend on //starboard concepts. Modifying it is not fully desirable (complicates future uprevs), however the CL tries to make the delta easy to rebase. b/371272304
Draft
kaidokert
reviewed
Nov 4, 2024
|
Since this is a feature/ branch i can't push to it, so had to close this PR. Moved discussion to : #4375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan is a new rendering (and presentation, and more) API intended to replace
E/GL(ES). Starboard doesn't define it and it's likely unsupported by partners
(and even if it is, the status would be unknown and by experience not ready).
This CL/PR disables building it when starboard is defined.
On dependencies, //gpu is a low level folder (like //base) so it can depend on
//starboard concepts. Modifying it is not fully desirable (complicates future
uprevs), however the CL tries to make the delta easy to rebase.
b/371272304