shardtree: Use Tree constructors instead of struct creation
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
shardtree-node-creation
branch
from
48d93ab
to
49c2524
Compare
This makes it easier for us to track where new tree nodes are created, and how the node kinds are used within the `ShardTree` data model.
str4d
force-pushed
the
shardtree-node-creation
branch
from
49c2524
to
020a7d7
Compare
nuttycom
approved these changes
Jun 26, 2024
| } | ||
| (left, right) => Tree( | ||
| Node::Parent { | ||
| (left, right) => Tree::parent( |
There was a problem hiding this comment.
I wonder why this doesn't format as a single line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for us to track where new tree nodes are created, and how the node kinds are used within the
ShardTreedata model.