Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sdhc: Add MAX32 SDHC driver #83464

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mertekren
Copy link
Contributor

@mertekren mertekren commented Dec 31, 2024

This PR adds SDHC support for max32666fthr.

Implement SDHC driver for MAX32666fthr
Add sdhc0 instances for MAX32666 .dtsi file
Add SDHC to MAX32666fthr board driver list

tests:
.\tests\drivers\sdhc
image

.\samples\subsys\fs\fs_sample\

image

.\tests\drivers\disk\disk_performance
image

Dependencies:

@mertekren mertekren changed the title sdhc: max32: Add sdhc for max32666fthr drivers: sdhc: Add MAX32 SDHC driver Jan 3, 2025
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 3, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_adi zephyrproject-rtos/hal_adi@a9ca7d1 zephyrproject-rtos/hal_adi@d09e2a9 (main) zephyrproject-rtos/hal_adi@a9ca7d17..d09e2a93

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

dts/bindings/sdhc/adi,max32-sdhc.yaml Outdated Show resolved Hide resolved
boards/adi/max32666fthr/doc/index.rst Outdated Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Outdated Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Outdated Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Show resolved Hide resolved
* remove this with a better solution in future.
*/
k_sleep(K_MSEC(1));
ret = MXC_SDHC_SendCommand(&sd_cmd_cfg);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question here- is this function blocking? Or does it use interrupts within the HAL layer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's blocking. it loops in while() until register is complete/timeout. we'll try to add interrupt functionality in future.

@MaureenHelm MaureenHelm added this to the v4.1.0 milestone Jan 20, 2025
@mertekren
Copy link
Contributor Author

@mertekren I think you messed up your update to west.yml as it's doing a lot more than updating hal_adi :)

yes i rebased wrong, should be good now. thanks! :)

drivers/sdhc/sdhc_max32.c Outdated Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Outdated Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Show resolved Hide resolved
drivers/sdhc/sdhc_max32.c Outdated Show resolved Hide resolved
dts/arm/adi/max32/max32666.dtsi Outdated Show resolved Hide resolved
dts/bindings/sdhc/adi,max32-sdhc.yaml Outdated Show resolved Hide resolved
@mertekren mertekren force-pushed the add-max32-sdhc branch 2 times, most recently from 96adc08 to 005d7c2 Compare January 29, 2025 12:00
west.yml Outdated
revision: a9ca7d172152789a02439bbdfb94feb72e30553d
revision: pull/12/head
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zephyrproject-rtos/hal_adi#12 has been merged, so you can update this to the new SHA

@fabiobaltieri fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025
mertekren and others added 6 commits February 4, 2025 23:07
Pull in support that adds sdhc header from hal_adi

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
Include sdhc0 in MAX32666 devicetree and add devicetree bindings for
MAX32 SDHC driver

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
This commit adds MAX32666 SDHC driver.

Co-Authored-By: Anil Kara <Anil.Kara@analog.com>
Co-Authored-By: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
Signed-off-by: Mert Ekren <mert.ekren@analog.com>
Add SDHC to supported list for MAX32666FTHR

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
Add MAX32666fthr for fs_sample testing

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
Add MAX32666fthr sdhc to tests/drivers/disk/disk_performance

Signed-off-by: Mert Ekren <mert.ekren@analog.com>
@zephyrbot zephyrbot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants