Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fungible): define interface for EVM keeper reference #900

Merged
merged 10 commits into from
Aug 7, 2023
Merged

refactor(fungible): define interface for EVM keeper reference #900

merged 10 commits into from
Aug 7, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Aug 2, 2023 •
edited
Loading

Description

Use an interface for EVM keeper reference to remove coupling and allow mocking for unit tests

Closes: #879

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Aug 2, 2023
@lumtis lumtis marked this pull request as draft August 2, 2023 12:19
@lumtis lumtis marked this pull request as ready for review August 2, 2023 12:53
@lumtis lumtis requested a review from ws4charlie as a code owner August 3, 2023 15:16
@lumtis lumtis mentioned this pull request Aug 4, 2023
Merged
10 tasks
@brewmaster012 brewmaster012 merged commit 49fc568 into develop Aug 7, 2023
15 checks passed
@brewmaster012 brewmaster012 deleted the fungible-evm-keeper-interface branch August 7, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use interface for evm keeper in fungible module
2 participants
@lumtis @brewmaster012