attic-client/push: Add flag to read paths from stdin #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaofengli
force-pushed
the
push-from-stdin
branch
from
73708a0
to
265038a
Compare
zhaofengli
force-pushed
the
push-from-stdin
branch
from
f23ecaa
to
d74c67a
Compare
|
Thanks! Instead of consuming stdin all at once, I made it read line-and-line and batch the pushes like This makes long-running |
cole-h
approved these changes
Oct 4, 2024
Instead of eagerly consuming stdin, read line-by-line and feed into PushSession. This allows for a `nix-build | attic push` workflow.
zhaofengli
force-pushed
the
push-from-stdin
branch
from
d74c67a
to
c5764fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag (
-i/--stdin) to thepushsubcommand of the attic client. This would resolve #175 .Note that there is also #118 , which implements a similar behavior as a fallback for the
pushcommand.