Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs change for Zowe Explorer plug-in for IntelliJ IDEA #3855

Conversation

KUGDev
Copy link
Contributor

@KUGDev KUGDev commented Sep 5, 2024

Describe your pull request here:
Changes for Zowe Explorer plug-in for IntelliJ IDEA and Zowe Client Kotlin SDK

List the file(s) included in this PR:
See the files, included in the PR

After creating the PR, follow the instructions in the comments.

@anaxceron anaxceron added area: SDK Issues/content related to Zowe SDKs release: V3 Zowe V3 content review: doc Needs review by Doc Squad member labels Sep 9, 2024
@zFernand0
Copy link
Member

The build should be fixed on the v3-doc-branch now. Feel free to update your branch 🥳

@KUGDev KUGDev force-pushed the zowe-explorer-intellij-and-kotlin-sdk branch from 31c60e4 to 410a92a Compare September 9, 2024 21:32
@KUGDev
Copy link
Contributor Author

KUGDev commented Sep 9, 2024

The build should be fixed on the v3-doc-branch now. Feel free to update your branch 🥳

Did rebase
@anaxceron

Copy link

github-actions bot commented Sep 9, 2024

🚀 Deployed on https://66e1bdd12adcdc299da0d20e--zowe-docs-master.netlify.app

Copy link
Collaborator

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments re: style, grammar, etc.

```
import org.zowe.kotlinsdk
```
For the detailed information about how to install the library, refer to [the official installation guide for Zowe Client Kotlin SDK](https://zowe.github.io/zowe-client-kotlin-sdk/#installation)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "the" after "For", and end this sentence w/ a period.


For more information, see [Using Zowe IntelliJ plug-in](../user-guide/intellij-using.md).
To see more about it, you can start with [Zowe Explorer plug-in for IntelliJ IDEA use cases](../user-guide/intellij-use-cases.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we mean by "To see more about it"? Are we inviting people to use the plug-in?


<details className="zowe-faq">

<summary></summary>

You can read detailed user guide and find any information you need [here](https://plugins.jetbrains.com/plugin/18688-zowe-explorer/user-guide). Also, you can ask any questions in the Zowe Slack channel [#zowe-explorer-intellij](https://openmainframeproject.slack.com/archives/C020BGPSU0M).
You can start with the [use cases](../user-guide/intellij-use-cases.md) section of the usage guide and continue with all the other related sections that describe in details how to get started. Also, you can ask any questions in our [Zowe Slack channel (#zowe-explorer-intellij)](https://openmainframeproject.slack.com/archives/C020BGPSU0M).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"details" should be singular.

Also, this sentence is a bit awkward. Please edit to something like: Read the user guide(link) to learn about use cases and to learn how to install and use the plug-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "user guide" as a singular section

<summary></summary>

If you have something to introduce but there is no related issue in the project repo, then you can either create the issue by yourself or contact us to help you with it. See more information in the [CONTRIBUTION.md](https://github.com/zowe/zowe-explorer-intellij/blob/main/CONTRIBUTING.md) file.
In case you have any idea on how to improve our plug-in, or have an issue / a bugfix in mind, visit our [contribution guide](https://github.com/zowe/zowe-explorer-intellij/blob/main/CONTRIBUTING.md). Also, you can ask for help in our [Zowe Slack channel (#zowe-explorer-intellij)](https://openmainframeproject.slack.com/archives/C020BGPSU0M).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to: If you have ideas on how to improve the plug-in, or have an issue/bug fix in mind, visit the contribution guide(link).

3. Search for, and select, `Zowe Explorer`.

The Zowe Explorer marketplace details display on the right side of the window. The version number is located adjacent to the Zowe Explorer name.
All the details are described in our "step-by-step" guide [here](./troubleshoot-intellij)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change: See the guide(link) for instructions.

@KUGDev KUGDev force-pushed the zowe-explorer-intellij-and-kotlin-sdk branch from 410a92a to 7b2bcca Compare September 10, 2024 16:37
@KUGDev KUGDev force-pushed the zowe-explorer-intellij-and-kotlin-sdk branch from 7b2bcca to 32d72bc Compare September 11, 2024 14:20
Copy link
Collaborator

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made additional comments re: style, typos, etc. Please fix before merging the PR.

- Highlight all IntelliJ supported languages automatically and recognize them once opened from the mainframe.
The plug-in helps to:
- Start working with z/OS easily with no complex configurations
- Organize datasets on z/OS, files on USS into working sets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Data sets" is two words in Zowe Docs -- please change throughout the files in this PR

- Organize datasets on z/OS, files on USS into working sets
- Allocate datasets, create members, files and directories with different permissions
- Perform operations like renaming, copying and moving data in a modern way
- Edit datasets, files and members. Smart auto-save keeps your content both in the editor and on the mainframe in-sync
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no hyphen in "in sync"

@@ -34,7 +34,7 @@ Zowe technology can be used by a variety of mainframe IT and non-IT professional

<summary></summary>

Zowe consists of several components. The primary languages for API Mediation Layer are Java and JavaScript. Zowe CLI, Explorer for VSCode and Desktop are written in TypeScript. Explorer for IntelliJ is written in Kotlin, ZSS is written in C, while the cross memory server is written in metal C.
Zowe consists of several components. The primary languages for API Mediation Layer are Java and JavaScript. Zowe CLI, Explorer for VSCode and Desktop are written in TypeScript. Zowe Explorer plug-in for IntelliJ IDEA is written in Kotlin, ZSS is written in C, while the cross memory server is written in metal C.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zowe Docs uses the Oxford comma: "Zowe CLI, Explorer for VS Code, and Desktop ..."


### Why might I use Zowe IntelliJ plug-in versus a traditional ISPF interface to perform mainframe tasks?
### Why might I use the plug-in versus a traditional ISPF interface to perform mainframe tasks?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the question to "Why should I use ... " or "Why would I use ... "


<details className="zowe-faq">

<summary></summary>

You can read detailed user guide and find any information you need [here](https://plugins.jetbrains.com/plugin/18688-zowe-explorer/user-guide). Also, you can ask any questions in the Zowe Slack channel [#zowe-explorer-intellij](https://openmainframeproject.slack.com/archives/C020BGPSU0M).
You can start with [use cases](../user-guide/intellij-use-cases.md) section to learn about use cases and to learn how to install and use the plug-in. Also, you can ask any questions in our [Zowe Slack channel (#zowe-explorer-intellij)](https://openmainframeproject.slack.com/archives/C020BGPSU0M).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a word; capitalize the section title; remove one unnecessary "to learn": "You can start with the Use case section to learn about use case and how to install and ... "

Signed-off-by: Uladzislau <leksilonchikk@gmail.com>
@KUGDev KUGDev force-pushed the zowe-explorer-intellij-and-kotlin-sdk branch from 32d72bc to 8dff3d9 Compare September 11, 2024 15:39
@KUGDev KUGDev removed the request for review from janan07 September 12, 2024 17:03
@anaxceron anaxceron merged commit bddfb2e into zowe:v3-doc-branch Sep 12, 2024
3 checks passed
@KUGDev KUGDev deleted the zowe-explorer-intellij-and-kotlin-sdk branch September 12, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: SDK Issues/content related to Zowe SDKs release: V3 Zowe V3 content review: doc Needs review by Doc Squad member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants