feat: compatibility with webpack-subresource-integrity@5.1.0 #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - `integrity: true` now requires `webpack-subresource-integrity`>=`5.0.0` - webpack@3 support with its `after-emit` hook is dropped Closes: ztoben#451
Den-dp
commented
Dec 15, 2022
| compiler.hooks.emit.tapAsync(plugin, emitPlugin) | ||
| } else { | ||
| compiler.plugin('after-emit', emitPlugin) | ||
| } |
There was a problem hiding this comment.
removed since old API anyway doesn't have assetEmitted equivalent.
Den-dp
commented
Dec 15, 2022
| @@ -119,7 +119,7 @@ AssetsWebpackPlugin.prototype = { | |||
| if (self.options.includeAllFileTypes || self.options.fileTypes.includes(typeName)) { | |||
| const combinedPath = assetPath && assetPath.slice(-1) !== '/' ? `${assetPath}/${asset}` : assetPath + asset | |||
| const type = typeof typeMap[typeName] | |||
| const compilationAsset = compilation.assets[asset] | |||
| const compilationAsset = stats.assets.find(statAsset => statAsset.name === asset) | |||
There was a problem hiding this comment.
Such change works for my project, but I wonder when we have more than 1 asset?
Den-dp
commented
Dec 15, 2022
| hashFuncNames: ['sha384'], | ||
| enabled: true | ||
| }) | ||
| new SubresourceIntegrityPlugin() |
There was a problem hiding this comment.
https://github.com/waysact/webpack-subresource-integrity/releases/tag/v5.0.0 brings new defaults.
Configuration is not needed anymore, they even recommend using it like that https://github.com/waysact/webpack-subresource-integrity/blob/main/MIGRATE-v1-to-v5.md#new-usage-suggested-defaults-recommended
note that the peerDependency already says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
integrity: truenow requireswebpack-subresource-integrity>=5.0.0after-emithook is droppedCloses: #451