Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coordinate frames conform with convention #91

Merged

Conversation

cpr-fer
Copy link
Contributor

@cpr-fer cpr-fer commented May 3, 2023

TODO:

  • Add tool0 frame
  • Fix gripper coordinate systems
  • Adapt examples to new coordinate systems
  • Test examples

@cpr-fer cpr-fer self-assigned this May 3, 2023
@cpr-fer cpr-fer linked an issue May 3, 2023 that may be closed by this pull request
@cpr-fer cpr-fer force-pushed the 85-gripper-coordinate-systems-do-not-follow-the-convention branch 3 times, most recently from 79c9332 to 96d62ca Compare May 4, 2023 09:53
@cpr-fer cpr-fer force-pushed the 85-gripper-coordinate-systems-do-not-follow-the-convention branch from 646f6c7 to fcf6cd3 Compare May 9, 2023 09:43
@cpr-fer cpr-fer force-pushed the 85-gripper-coordinate-systems-do-not-follow-the-convention branch from cad3d3b to 73d7f56 Compare May 9, 2023 12:39
@cpr-fer
Copy link
Contributor Author

cpr-fer commented May 12, 2023

The vacuum example has some issues, see #101 for more details regarding the gripper issue, the other one is related to adapting the positions of the trays to a good place for the rebel.

The other two are working fine though now, as such I'll be merging this soon

@JHeuverRiwo If you encounter any issues with movements now you need to double-check all orientations as they might have changed.

@cpr-fer cpr-fer marked this pull request as ready for review May 12, 2023 10:03
@cpr-fer cpr-fer merged commit b29cf87 into humble May 12, 2023
@cpr-fer cpr-fer deleted the 85-gripper-coordinate-systems-do-not-follow-the-convention branch May 12, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gripper coordinate systems do not follow the convention
1 participant