-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.4.0-preview2 support for CircleCI tests #4040
Conversation
dd6e6b1
to
3dc6500
Compare
BenchmarksBenchmark execution time: 2024-11-08 21:02:17 Comparing candidate commit f1c7fe4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
a31a225
to
5f9c920
Compare
a91d722
to
8d98ec7
Compare
3bceef3
to
275bb2f
Compare
7f6cef7
to
53f6d72
Compare
Could be fixed by requiring |
The following makes the test pass on ruby-3.4 config:
I haven't checked if this would also work on rack 3.0, and I am quite certain this will NOT work on rack 2 and lower therefore the change needs to be conditional on rack version. |
616046e
to
602a389
Compare
724b1cb
to
00e02df
Compare
Slight suggestion: This PR is getting so big at this point that GitHub literally does not show me the complete list of files changed when I go on the diff tab. May be worth splitting some of the changes into smaller PRs that could go in already? E.g. maybe a separate PR for the ffi/webrick stuff, that doesn't even add 3.4 yet, etc? |
ccc80ce
to
bfeecc3
Compare
This PR was split up. See #4114 . |
What does this PR do?
This PR adds "3.4" versions to the
config.yml
file under.circleci
everywhere there is a comment to# ADD NEW RUBIES HERE
.Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.
Change log entry
No change log entry for now. Thinking to have a "Ruby 3.4.0-preview2 support added" update after it is fully supported.
Additional Notes:
This PR is one step toward full support and only addresses CircleCI workflow tests. It acts alongside #4038 and #4039 .
How to test the change?
This change can be tested in CI.