Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models refactoring #83

Merged
merged 28 commits into from
Mar 14, 2024
Merged

Models refactoring #83

merged 28 commits into from
Mar 14, 2024

Conversation

christinab12
Copy link
Collaborator

Major changes in dcp-server:

  • models file was split into one file for each model
  • refactoring of code in fsimastorage to deal with some image processing which was previously taking place in models
  • created utils folder and helper preprocessing files

These changes address issues #78 #76 #65

Additionally:

  • moved from cfg config files to yaml
  • include update in CI/CD

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 82.71605% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 84.44%. Comparing base (1f0654b) to head (7c7500b).
Report is 2 commits behind head on main.

Files Patch % Lines
src/client/dcp_client/gui/napari_window.py 71.18% 17 Missing ⚠️
src/client/test/test_compute4mask.py 46.42% 15 Missing ⚠️
src/client/dcp_client/app.py 62.06% 11 Missing ⚠️
src/client/dcp_client/utils/compute4mask.py 88.15% 9 Missing ⚠️
src/client/test/test_main_window.py 78.12% 7 Missing ⚠️
src/client/dcp_client/gui/main_window.py 88.63% 5 Missing ⚠️
src/client/test/test_napari_window.py 75.00% 5 Missing ⚠️
src/client/dcp_client/utils/bentoml_model.py 77.77% 4 Missing ⚠️
src/client/dcp_client/utils/utils.py 77.77% 4 Missing ⚠️
src/client/dcp_client/gui/welcome_window.py 90.32% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   88.68%   84.44%   -4.24%     
==========================================
  Files          25       20       -5     
  Lines        1891     1260     -631     
==========================================
- Hits         1677     1064     -613     
+ Misses        214      196      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christinab12 christinab12 merged commit baa6e03 into main Mar 14, 2024
8 of 18 checks passed
@francesco-campi francesco-campi deleted the models-refactoring branch July 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants