Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuwait Theme: Map View Styling #2669

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Kuwait Theme: Map View Styling #2669

wants to merge 13 commits into from

Conversation

FaithDaka
Copy link
Collaborator

@FaithDaka FaithDaka commented Jan 2, 2025

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

  • Styling support added for a curved map path

Author Notes

  • The Kuwait map design has paths that wind a lot more than the wavy variant accommodates. A new variant, curved, is added in this update to support curvier paths.
  • The task card now includes an additional attribute, locked_image_asset, to accommodate the locked icon that appears on top of the module.

Attributes added to sheet:

  • variant: "curved"
  • locked_image_asset

Git Issues

Closes #2667

Screenshots

To visualise the map path, the color stroke here is dark

Otherwise the map path is a light color to contrast with the proposed background image

A completed module is highlighted with a blue border while an in_progress module is highlighted with a yellow border

@FaithDaka FaithDaka linked an issue Jan 2, 2025 that may be closed by this pull request
@FaithDaka FaithDaka self-assigned this Jan 2, 2025
@FaithDaka FaithDaka requested a review from jfmcquade January 2, 2025 15:16
@FaithDaka FaithDaka added this to the ParentApp Kids KW Dec 2024 milestone Jan 2, 2025
@FaithDaka FaithDaka added the feature Work on app features/modules label Jan 2, 2025
@FaithDaka
Copy link
Collaborator Author

For your review @jfmcquade @esmeetewinkel

@FaithDaka FaithDaka changed the title Feature kw map view Kuwait Theme: Map View Styling Jan 3, 2025
Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new path style looks nice. However, it doesn't reflect the design and so won't line up with the background image in the same way. I think that will have to be addressed in the future as a follow-up, appreciate this could be quite difficult to implement.

I've tidied and clarified some of the logic with b7263f4.

Additionally, I think we'll need to handle the "locked" status differently. @esmeetewinkel – currently, this PR sets the "locked" status through the same logic that determines the completion status of the task group: namely, if the task group is "not started" (i.e. none of its constituent tasks are completed), then the task group is considered "locked". However, this doesn't allow us to handle unlocking task groups. If the task group is not clickable when it is locked, then there I don't believe there is a way for the user to begin that task group. If the task group is clickable when locked, then the "locked" status is misleading. So I think we need to handle the "locked" status via a dedicated parameter, and handle the logic elsewhere (e.g. in a dedicated locked column that gets updated through template logic). Does that sound right to you @esmeetewinkel? If so, I can update this PR. I think if we need to rush something in the short-term, we could leave the code as-is which would mean that a locked task-group could still be clicked on to enter that module.

@esmeetewinkel
Copy link
Collaborator

(e.g. in a dedicated locked column that gets updated through template logic). Does that sound right to you @esmeetewinkel?

Yes that sounds right

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @esmeetewinkel, I've updated to expose an explicit locked param. See final example in updated comp_progress_path template

Screenshot 2025-01-03 at 19 09 23 Screenshot 2025-01-03 at 19 09 28 Screenshot 2025-01-03 at 19 08 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Kuwait Theme - Map View
3 participants