Introduce FileDoesNotExistError and bump to ouroboros-consensus 0.8
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
carbolymer and
disassembler
as code owners
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
c652b53
to
a999f28
Compare
newhoggy
force-pushed
the
main
branch
2 times, most recently
from
4e5cfdd
to
1abeff1
Compare
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
2 times, most recently
from
69ada4d
to
efca823
Compare
carbolymer
reviewed
Jun 22, 2023
carbolymer
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Can you reformat changed files, please?
@newhoggy @Jimbo4350 It would be nice if you could have a look too.
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
2 times, most recently
from
92a3477
to
a5aff8c
Compare
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
a5aff8c
to
a0b4040
Compare
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
a0b4040
to
c12194d
Compare
|
Bump @carbolymer |
coot
reviewed
Jul 3, 2023
6 tasks
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
0a0735a
to
e2ef4a9
Compare
carbolymer
reviewed
Jul 6, 2023
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
e2ef4a9
to
52c5582
Compare
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
52c5582
to
d7469f4
Compare
carbolymer
approved these changes
Jul 6, 2023
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
d7469f4
to
224d7dc
Compare
Jimbo4350
reviewed
Jul 6, 2023
bolt12
changed the title
FileDoesNotExistError
Jimbo4350
changed the title
FileDoesNotExistErrorFileDoesNotExistError and Bump to ouroboros-consensus 0.8
Jimbo4350
changed the title
FileDoesNotExistError and Bump to ouroboros-consensus 0.8FileDoesNotExistError and bump to ouroboros-consensus 0.8
Jimbo4350
approved these changes
Jul 6, 2023
Improves the error situation when dealing with file paths. Before all IO related errors where wrapped around the constructor FileIOError. Now the existence of the file is checked and if it does not exist a FileDoesNotExistError is thrown. Added `fileIOExceptT` function that abstracts away this existence check, so we can get read of all the FileIOError wraps.
bolt12
force-pushed
the
bolt/dynamic-block-forging
branch
from
870ba54
to
cc7d8b5
Compare
|
Closed in favor of #99 |
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…th-voting-and-actions Update tx build with voting and actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to IntersectMBO/ouroboros-consensus#140 and is needed in order for IntersectMBO/cardano-node#4024 to compile.
Changelog