Dynamic block forging for the P2P mode #4024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
deepfire,
denisshevchenko,
jutaro,
MarcFontaine,
mgmeier,
cleverca22,
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
coot
force-pushed
the
coot/dynamic-block-forging
branch
from
3f667be
to
3b52070
Compare
9 tasks
coot
force-pushed
the
coot/dynamic-block-forging
branch
from
3b52070
to
f13bf8f
Compare
coot
force-pushed
the
coot/dynamic-block-forging
branch
2 times, most recently
from
b142e38
to
f757059
Compare
nfrisby
reviewed
Jun 13, 2022
There was a problem hiding this comment.
All the data flow looks reasonable to me. 👍
I'm not Approving, because I'm not Node and also I didn't review the handler logic -- I only double-checked that the new handler calls the function I was expecting it would. So I Approve those parts, but I didn't review everything.
|
This work is ongoing. |
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
f757059
to
c9fc1c9
Compare
bolt12
requested review from
a team,
fmaste,
carbolymer and
LaurenceIO
as code owners
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
c9fc1c9
to
9304ae9
Compare
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
9304ae9
to
ff0dce6
Compare
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
ff0dce6
to
ed2a73d
Compare
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
3 times, most recently
from
63ba255
to
20d8f19
Compare
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
20d8f19
to
a1d0c3a
Compare
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
9cc9107
to
1594803
Compare
Make code type check
- The moving of UseLedger was needed in order to import `Cardano.Node.Protocol (ProtocolInstantiationError)` - Added new constructors to Startup Tracer
Block Forging can be enabled/disabled through SIGHUP signal. Sending such a signal will trigger the node to read the block forging credential files. Since the credential files are passed via CLI flags one can not remove them without restarting the node. For this effect, in order for one to be able to disable block forging, moving/renaming/deleting the file at the specified path (for the credential flags) and then sending the SIGHUP signal is what needs to be done. The code will detect that the specified files do not exist and it will disable block forging, while tracing the appropriate log messages. In case one wants to start a block producing node (i.e. passing the credentials in the respective flags) but doesn't want it to actually behave as a BP, there's a new `--start-as-non-producing-node` flag that will run the node with credentials as a normal node. However on SIGHUP it will read the credential files and start forging. Refactor code to accomodate the changes Added EnabledBlockForging type Co-authored-by: Marcin Szamotulski <coot@coot.me>
bolt12
force-pushed
the
coot/dynamic-block-forging
branch
from
1594803
to
9350e00
Compare
coot
removed request for
deepfire,
JaredCorduan,
MarcFontaine,
denisshevchenko and
LaurenceIO
6 tasks
|
Closed in favor of #5383 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces dynamic updates to the block forging configuration, enabling and disabling block forging through the SIGHUP signal. It addresses issue input-output-hk/ouroboros-network#3159 and relies on changes in ouroboros-consensus#140 and cardano-api#45.
Main changes:
Dependencies Update: The
ouroboros-consensusandcardano-apidependencies have been updated to accommodate the changes needed for this feature.Improved Import Structure: The
UseLedgertype was moved to prevent cyclic imports, improving the overall import structure.Adding of
SomeBlockTypeandReflBlockTypeHow it works:
Block forging can now be dynamically enabled/disabled through SIGHUP signal. This is done by triggering the node to read the block forging credential files upon receiving the signal. To disable block forging, one must move/rename/delete the file at the specified path (for the credential flags) and then send the SIGHUP signal. The code will then disable block forging and trace the appropriate log messages.