perf: parallelize S3 segment and index uploads#110
Merged
novatechflow merged 2 commits intoKafScale:mainfrom Feb 25, 2026
Merged
perf: parallelize S3 segment and index uploads#110novatechflow merged 2 commits intoKafScale:mainfrom
novatechflow merged 2 commits intoKafScale:mainfrom
Conversation
Upload .kfs and .index files concurrently using errgroup to eliminate one sequential S3 round-trip from the produce path. Side effects (cache population, segment list update) are deferred until both uploads succeed. Closes KafScale#109
Collaborator
Collaborator
|
it’s in the test callback: ( |
Contributor
Author
|
@novatechflow thanks for pointing that out! |
novatechflow
approved these changes
Feb 25, 2026
Collaborator
novatechflow
left a comment
novatechflow
left a comment
There was a problem hiding this comment.
thank you @klaudworks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #109
Summary
.kfsand.indexfiles concurrently influshLocked()usingerrgroup, eliminating one sequential S3 round-trip from the produce path.Details
The two S3 uploads are independent — neither depends on the other's result.
errgroup.WithContextis used so that if one upload fails, the other's context is cancelled promptly. TheonS3Opcallback still reports individual per-upload timings.