Skip to content

perf: parallelize S3 segment and index uploads #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
novatechflow merged 2 commits into from
Feb 25, 2026
Merged

perf: parallelize S3 segment and index uploads #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
343e7f9
perf: parallelize S3 segment and index uploads in flushLocked
klaudworks Feb 24, 2026
4ae09e5
fix: use atomic counter in test to avoid data race with parallel uploads
klaudworks Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions pkg/storage/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"time"

"github.com/KafScale/platform/pkg/cache"
"golang.org/x/sync/errgroup"
)

// PartitionLogConfig configures per-partition log behavior.
Expand Down Expand Up @@ -242,21 +243,25 @@ func (l *PartitionLog) flushLocked(ctx context.Context) (*SegmentArtifact, error
segmentKey := l.segmentKey(artifact.BaseOffset)
indexKey := l.indexKey(artifact.BaseOffset)

start := time.Now()
uploadErr := l.s3.UploadSegment(ctx, segmentKey, artifact.SegmentBytes)
if l.onS3Op != nil {
l.onS3Op("upload_segment", time.Since(start), uploadErr)
}
if uploadErr != nil {
return nil, uploadErr
}
start = time.Now()
uploadErr = l.s3.UploadIndex(ctx, indexKey, artifact.IndexBytes)
if l.onS3Op != nil {
l.onS3Op("upload_index", time.Since(start), uploadErr)
}
if uploadErr != nil {
return nil, uploadErr
g, gctx := errgroup.WithContext(ctx)
g.Go(func() error {
start := time.Now()
err := l.s3.UploadSegment(gctx, segmentKey, artifact.SegmentBytes)
if l.onS3Op != nil {
l.onS3Op("upload_segment", time.Since(start), err)
}
return err
})
g.Go(func() error {
start := time.Now()
err := l.s3.UploadIndex(gctx, indexKey, artifact.IndexBytes)
if l.onS3Op != nil {
l.onS3Op("upload_index", time.Since(start), err)
}
return err
})
if err := g.Wait(); err != nil {
return nil, err
}
if l.cache != nil && l.cfg.CacheEnabled {
l.cache.SetSegment(l.cacheTopicKey(), l.partition, artifact.BaseOffset, artifact.SegmentBytes)
Expand Down
9 changes: 5 additions & 4 deletions pkg/storage/log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package storage
import (
"context"
"encoding/binary"
"sync/atomic"
"testing"
"time"

Expand Down Expand Up @@ -143,7 +144,7 @@ func TestPartitionLogReadUsesIndexRange(t *testing.T) {
func TestPartitionLogReportsS3Uploads(t *testing.T) {
s3 := NewMemoryS3Client()
c := cache.NewSegmentCache(1024)
var uploads int
var uploads atomic.Int64
log := NewPartitionLog("default", "orders", 0, 0, s3, c, PartitionLogConfig{
Buffer: WriteBufferConfig{
MaxBytes: 1,
Expand All @@ -153,7 +154,7 @@ func TestPartitionLogReportsS3Uploads(t *testing.T) {
IndexIntervalMessages: 1,
},
}, nil, func(op string, d time.Duration, err error) {
uploads++
uploads.Add(1)
})

batchData := make([]byte, 70)
Expand All @@ -165,8 +166,8 @@ func TestPartitionLogReportsS3Uploads(t *testing.T) {
if err := log.Flush(context.Background()); err != nil {
t.Fatalf("Flush: %v", err)
}
if uploads < 2 {
t.Fatalf("expected upload callback for segment + index, got %d", uploads)
if uploads.Load() < 2 {
t.Fatalf("expected upload callback for segment + index, got %d", uploads.Load())
}
}

Expand Down