Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SDK feature disablers + USB disabler fix with DEBUG builds #397

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Aug 2, 2023

Description

  • Building an app with disabled USB would not work with DEBUG builds since on devices other that the Nano S, the printf implementation uses the USB
  • The UI (NBGL or BAGL) can be completely disabled for faster compilation when not needed (Ethereum plugins for example)
  • Fixed builds with seproxyhal not enabled + added a disabler for it in the standard_app Makefile
  • Breaking change for Stax apps that use the QR code feature without explicitly adding its source path

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d31f67c) 69.09% compared to head (e3f4693) 69.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         864      864           
=======================================
  Hits          597      597           
  Misses        267      267           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on many apps :/

Makefile.defines Show resolved Hide resolved
@@ -33,18 +33,26 @@ void io_start(void) {
void bolos_init_ios(void) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I' didn't know this exists... this is somehow a duplicate of what's done in lib_standard_app/main.c: common_app_init(). Maybe we can merge?

Makefile.standard_app Outdated Show resolved Hide resolved
@apaillier-ledger apaillier-ledger force-pushed the feat/apa/sdk_improvements branch 2 times, most recently from 76e4f98 to b105c0e Compare August 2, 2023 16:10
Makefile.defines Outdated Show resolved Hide resolved
This was referenced Aug 3, 2023
@apaillier-ledger apaillier-ledger merged commit f5eb07f into master Aug 9, 2023
160 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/sdk_improvements branch August 9, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants