free orig parameters after sharding #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review, but I'm marking as draft for the target branch. |
crcrpar
reviewed
Aug 18, 2024
Co-authored-by: Masaki Kozuki <mkozuki@nvidia.com>
IvanYashchuk
approved these changes
Aug 19, 2024
crcrpar
approved these changes
Aug 19, 2024
t-vi
force-pushed
the
tom/fsdp-composable-step2
branch
from
b663385 to
2357aad
Compare
|
Thank you @crcrpar @IvanYashchuk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
This is an alternative to #932 also covering the original #478 that leverages the Thunder meta tensor handling for the MaterializationTransform.
It builds on #986 (I need to change the target branch if that is merged.)
The test has been taken (and parametrized to cover cuda and meta) from #932 (all credit to @crcrpar ).
Thank you @kshitij12345 for the reproducer.