Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing fstring on error message #4638

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

marinegor
Copy link
Contributor

@marinegor marinegor commented Jul 21, 2024

Fixes #

Changes made in this Pull Request:

  • make string an fstring to ensure particular atom is printed correctly

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4638.org.readthedocs.build/en/4638/

@pep8speaks
Copy link

pep8speaks commented Jul 21, 2024

Hello @marinegor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 322:80: E501 line too long (92 > 79 characters)

Comment last updated at 2024-07-24 16:47:44 UTC

Copy link

github-actions bot commented Jul 21, 2024

Linter Bot Results:

Hi @marinegor! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/10080710515/job/27871085689


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (1bf58cc) to head (ba4cb02).
Report is 34 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4638      +/-   ##
===========================================
- Coverage    93.61%   93.59%   -0.03%     
===========================================
  Files          171      183      +12     
  Lines        21250    22320    +1070     
  Branches      3936     3937       +1     
===========================================
+ Hits         19893    20890     +997     
- Misses         898      971      +73     
  Partials       459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but it seems like a test is either not working or doesn't exist.

@@ -319,7 +319,7 @@ def __init__(
):
raise ValueError(
(
"Residue {calpha.residue} contains wrong number of hydrogens: "
f"Residue {calpha.residue} contains wrong number of hydrogens: "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this covered by a test? I.e. if it is, why did the error message matching not fail? If it isn't, then we should cover it by a test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IAlibay fixed, thanks.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks!

@orbeckst orbeckst merged commit 7302719 into MDAnalysis:develop Jul 25, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants