Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing fstring on error message #4638

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix missing fstring on error message #4638

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ec401
Fix missing fstring on error message
marinegor Jul 21, 2024
ba4cb02
Add test for raised exception text in DSSP
marinegor Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/MDAnalysis/analysis/dssp/dssp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def __init__(
):
raise ValueError(
(
"Residue {calpha.residue} contains wrong number of hydrogens: "
f"Residue {calpha.residue} contains wrong number of hydrogens: "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this covered by a test? I.e. if it is, why did the error message matching not fail? If it isn't, then we should cover it by a test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IAlibay fixed, thanks.

"exactly 1 hydrogen is expected for non-PRO residues, and "
"zero hydrogens for PRO residues."
)
Expand Down
Loading