simplify-dataset-init #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
commented
Sep 18, 2024
| self.software: str = loader.software | ||
| self._gene_names: str = loader.gene_names | ||
|
|
||
| self._intensity_column: Union[str, list] = ( |
There was a problem hiding this comment.
note that this was different before:
loader.intensity_column was used to create the mat object, and only afterwards overwritten in the case of a generic loader .. I suppose this was not intended
boopthesnoot
approved these changes
Sep 20, 2024
| sample_column: Optional[str] = None, | ||
| ): | ||
| """Create DataSet | ||
|
|
||
| Args: | ||
| loader (_type_): loader of class AlphaPeptLoader, MaxQuantLoader, DIANNLoader, FragPipeLoader, SpectronautLoader | ||
| metadata_path (str, optional): path to metadata file. Defaults to None. | ||
| metadata_path (str or pd.DataFrame, optional): path to metadata file or an actual df. Defaults to None. |
There was a problem hiding this comment.
Suggested change
| metadata_path (str or pd.DataFrame, optional): path to metadata file or an actual df. Defaults to None. | |
| metadata_path_or_df (str or pd.DataFrame, optional): path to metadata file or an actual df. Defaults to None. |
sorry to be this person hahaha
There was a problem hiding this comment.
this is indeed a good suggestion to make this api better .. in the long run, I'd implement two distinct parameters (path and df) .. did the whole change here: #336
|
This looks good to me, wlthough I am not sure the functionalitz provided by the dataset factory really need to/should be separated, as this defines the core of the DataSet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some of the init logic to a new class.
Now the DataSet class should contain next to no logic anymore.