Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename metadata_path -> metadata_path_or_df #336

Merged
merged 3 commits into from
Sep 20, 2024
Merged

rename metadata_path -> metadata_path_or_df #336

merged 3 commits into from
Sep 20, 2024

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Sep 20, 2024 •
edited
Loading

implementing this suggestion: #333 (comment)

@mschwoer mschwoer mentioned this pull request Sep 20, 2024
Merged
Base automatically changed from linitin-rule-SIM to development September 20, 2024 22:02
@mschwoer mschwoer merged commit 68dbd34 into development Sep 20, 2024
2 of 5 checks passed
@mschwoer mschwoer deleted the rename_metadat_param branch September 20, 2024 22:20
boopthesnoot
boopthesnoot reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@boopthesnoot boopthesnoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boopthesnoot boopthesnoot boopthesnoot left review comments

@JuliaS92 JuliaS92 Awaiting requested review from JuliaS92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @boopthesnoot