Speed improvements when writing XML containing multiple wells #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures multithreading compatibility across operating systems
use multi processing for cellsets Each of these processes can then have multiple threads underneath it
sophiamaedler
added a commit
to MannLabs/scPortrait
that referenced
this pull request
Jul 10, 2024
adapts changes implemented in PR MannLabs/py-lmd#11 from py-lmd
Update repo and testcases
GeorgWa
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when trying to generate an XML whereN cells are sorted into Z wells the coordinate locations for each cell were recalculated for each well. This PR implements improvements to the workflow that only calculates required values once and reloads them when required. This provides a significant speed improvement when generating XMLs where Z is high.
In addition multithreading has been implemented to allow for the parallel calculation of XML coordinates for multiple cell sets. This can be set by providing an additional parameter (
threads) to the segmentation loader. Per default this parameter is set to 1 to disable multi-threading.