[Bounty] The Arti-Re-Factoring Base #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More testing required however.
Untested. Probably works tho.
God forbid death actually rolls.
Hell yea we ballin now.
New effect: Money, Makes it sell well. weighted artifact effects/faults Plushie artifact effect greg artifact effect, clown portal artifact effect
dwasint
requested changes
Aug 26, 2024
monkestation/code/modules/art_sci_overrides/artifact_components/_artifact_effect.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/art_sci_overrides/artifact_components/_base_component.dm
Outdated
Show resolved
Hide resolved
Effects now have their own folder, as well as the "holder" being just an object. instead of a specific object.
God dammit Im a dumbass New Effect: its a secret. Fixes bug causing effects to just not trigger!
This was referenced Aug 26, 2024
Should stop artifact effect spam Also tweaks a couple artifact effects
Leftovers from the port.
Closed
Annoying.
Dammit stop PANIC PUSHING LEN
This was referenced Aug 27, 2024
Open
VERYRARE artifacts now rarer. Greg and Plushie now work at least somewhat properly touch components now work its a secret now rarer and there for less time. artifacts correctly obey size. analasis form exports correctly say no longer runtimes
Why are they so fast on my test instance, no idea!
This was referenced Aug 27, 2024
This was referenced Sep 8, 2024
Yep thats the whole push a "the the" fix.
This was referenced Sep 9, 2024
This was referenced Sep 11, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Moderate refactor of the artifact system, and how it interacts with the rest of the station.
Do note: While I have tested this, I am not a perfect tester. I will be splitting the PR into multiple parts over time to [Hopefully] include more things such as even more effects, faults, activators, etc.
Should not effect mapping in any way, as all changes were done internally.
Why It's Good For The Game
Bounty. Also, artifacts are a dead system IMO and need the love. I've never seen miners even bring up the danm things.
This should help enforce station cross interaction, as once an artifact is researched, there isnt much for sci to do with it other than exploit its effects, or label and throw at cargo for money!
Also feel free to laugh at me I accidentally tried to merge this upstream.
Changelog
🆑
add: New Artifact Effects
add: New Artifact Faults
add: New Artifact Manipulation wand
add: New Artfact Manipulation Disks
change: Any object may now be an artifact
change: The Xray machine now reveals artifact effects,including faults and activators; instead of just randomly activating them
change: Artifact stickers will now imply a cargo value based on how 'Correct' they are, as well as effects themselves straight up being valuable!
change: Artifacts On scan by X-ray machine give Science research points!
qol: Artifacts now explain what they do better based on if their effect has been discovered or not.
refactor: Artifacts may now have multiple effects
refactor: Artifacts are no-longer their own object, instead, have more component datums attached to them, making code much easier to create non-'Statue' artifacts.
code: New datum/artifact_effect for artifacts. Simply slap it on the existing holder and you're good!
refactor: UI for Artifact stickers changed to allow multiple effects selected.
/:cl: