Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Formatting and syntax fixes #147

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

nickelpro
Copy link
Member

@nickelpro nickelpro commented Feb 7, 2024

This PR is a courtesy because it will break outstanding work that will need to be rebased. This will merge in a day or two if there's no other issues.

Build:

  • Update vcpkg bootstrapping to new style
  • Inline vcpkg-configuration.json
  • Update baselines

Style:

  • Reformat all SystemVerilog files with verible-format, might add this to the component template to be enforced always
  • or -> ,

Function:

  • Fix all verilog-style always blocks -> SV-style always_ff blocks
  • Fix all blocking assignments in non-blocking contexts
  • Fix a couple missing semi-colons
  • Normalize all port lists, necessary for some synthesizers (Quartus) ((and also just good practice))

Refactor:

  • Significantly simplify Alu.sv, don't try to out-smart the synthesizer (this isn't comp arch, if you want a less-than you can just use less-than)
  • Avoid unnecessary clock-gate latch in Branch_Manager.sv

Build:
* Update vcpkg bootstrapping to new style
* Inline vcpkg-configuration.json
* Update baselines

Style:
* Reformat all system verilog files with verible-format
* " or " -> ", "

Function:
* Fix all verilog-style always blocks -> SV-style always_ff blocks
* Fix all blocking assignments in non-blocking contexts
* Fix a couple missing semi-colons
* Normalize all port lists, necessary for some synthesizers (Quartus)

Refactor:
* Significantly simplify Alu.sv, don't try to out-smart the synthesizer
* Avoid unnecessary clock-gate latch in Branch_Manager.sv
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e74b8c0) 97.86% compared to head (44066ae) 98.18%.

Files Patch % Lines
rtl/Branch_Predictor.sv 87.50% 2 Missing ⚠️
rtl/IDEX.sv 95.65% 1 Missing ⚠️
rtl/Pipeline_Reset.sv 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   97.86%   98.18%   +0.32%     
==========================================
  Files          13       13              
  Lines         234      276      +42     
==========================================
+ Hits          229      271      +42     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickelpro
Copy link
Member Author

Also coverage is completely broken because of a bug in the way tests are done, that fix is coming in a separate PR

@ShinyMiraidon ShinyMiraidon merged commit 948ade6 into NYU-Processor-Design:main Feb 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants