8. Requesting Reviewers
Once you think you have a great prototype or a final product, it is time to request reviewers! Generally, a code review should not contain more than 100 lines of changes in one file (unless you are pushing the skeleton of a package).
Ensure that you are a member of our GitHub organization. If you cannot view the members in the Org, please follow the steps listed here.
Create a (public or private) repository in the organization for the project that needs reviewing. Remember that this repository will be used throughout your development for CR, so please make sure to use an appropriate name (not "TestRepo") and provide a good description in the Repository Description section.
Create a fork from the GitHub org to your own personal account. All your development code and prototyping must be done in your personal repository prior to doing a PR.
Prior to doing a pull request, which is necessary for others to review your code, commit your code changes and developments to your personal fork.
Once your code is ready for review, go to the upstream repository (main repo on the org) and do a pull request. Make sure to look at your personal fork when creating a pull request. The general steps are:
Pull Requests > New Pull Request > (selecting) compare across forks (Also shown below)
A good pull request must be between 15 - 100 lines of code. Make sure to explain changes/implementations very well in the description of the changes that you will submit. A clear and well-explained description of your PR is very important for the reviewing process as the reviewer may not be entirely familiar with your work.
Once you have submitted a PR, you can request a reviewer from the right-hand panel of the PR page (as shown below). It is a good idea to let the reviewer know prior to requesting them.
That's it! From here on, you can keep committing to your local fork and the changes will appear as part of the pull request!