fix: remove old iqp authentication #1788
Conversation
ElePT
left a comment
ElePT
left a comment
There was a problem hiding this comment.
Good to see the old IQP logic going away :) I just have a small change request.
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
|
Another quick comment, I would add a release note describing the change. You can find instructions on how to use |
Great! thanks! I'll start working on it |
…kit-serverless into remove-old-iqp-authentication
Done! |
| @@ -1,5 +1,5 @@ | |||
| coverage>=5.5 | |||
| pylint>=2.17.7 | |||
| pylint>=3.0.0 | |||
There was a problem hiding this comment.
Just curious about why this change?
There was a problem hiding this comment.
I got an error during the lint step saying a rule didn’t exist. It was probably due to my local pylint setup. Updating and reinstalling pylint fixed it. I know this wasn’t the real cause of the problem, but I figured it wouldn’t hurt.
ElePT
left a comment
ElePT
left a comment
There was a problem hiding this comment.
Looks good on my side, I am also in favor of updating pylint if tests pass.
|
How we are in the middle of the release I would like to pospone this merge until we finish. |
5 participants
Summary
This PR removes the old IQP authentication flows
Details and comments